Not enough tests against Actionlogs during check-in and check-out (and possibly others)

[uberbrady]

While working on #16839 , I noticed I had some bugs around action_type as well counts of various Actionlogs. For instance, on creating a new asset via API that has an assigned_user, is that one Actionlog or two?

So I'd like to see a chunk of new tests around action logs - checking counts of logs, and types of action_type - and then when I merge in those changes, I'm expecting to see my PR start to fail and will be able to fix them.

I'm mostly seeing this around checkin/checkout on creation - mostly via GUI but quite possibly via importer as well. And, checkin/checkout is slightly different between API and GUI - which is a whole other issue that I'm concerned about but not something we have to do here.

I already introduced some checkin/checkout tests (for both API and GUI) around counters - and maybe we can add some more tests in there?

[marcusmoore]

I think it would be helpful to have a new test helper that was something like:

function assertActionLogCreated($type, $target = null, $item = null, $actor = null)
{
    $actor  = $actor ?? auth()->user();
    
    $this->assertDatabaseHas('action_logs', [
        'created_by' => $actor->id,
        'action_type' => $type,
        'target_id' => $target ? $target->id : null,
        'target_type' => $target ? get_class($target) : null,
        'item_type' => $item ? get_class($item) : null,
        'item_id' => $item ? $item->id : null,
    ]);
}

$this->assertActionLogCreated(
    'delete',
    $target,
    $item,
);

I can see adding that in this chunk of work being useful.

[uberbrady]

I ended up doing something close to that - I’ll push it up later