Remove named returns from newPageContext

inancgumus · inancgumus · commit 2951829494e0 · 2022-01-18T16:56:22.000+03:00
diff --git a/common/browser.go b/common/browser.go
@@ -335,7 +335,7 @@ func (b *Browser) onDetachedFromTarget(ev *target.EventDetachedFromTarget) {
 	}
 }
 
-func (b *Browser) newPageInContext(id cdp.BrowserContextID) (page *Page, err error) {
+func (b *Browser) newPageInContext(id cdp.BrowserContextID) (*Page, error) {
 	b.contextsMu.RLock()
 	browserCtx, ok := b.contexts[id]
 	b.contextsMu.RUnlock()
@@ -374,6 +374,7 @@ func (b *Browser) newPageInContext(id cdp.BrowserContextID) (page *Page, err err
 	}
 	// let the event handler know about the new page.
 	targetID <- tid
+	var page *Page
 	select {
 	case <-waitForPage:
 		b.logger.Debugf("Browser:newPageInContext:<-waitForPage", "tid:%v bctxid:%v", tid, id)

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ func (b Browser) onDetachedFromTarget(ev target.EventDetachedFromTarget) {`
`335`	`335`	`}`
`336`	`336`	`}`
`337`	`337`
`338`		`-func (b Browser) newPageInContext(id cdp.BrowserContextID) (page Page, err error) {`
	`338`	`+func (b Browser) newPageInContext(id cdp.BrowserContextID) (Page, error) {`
`339`	`339`	`b.contextsMu.RLock()`
`340`	`340`	`browserCtx, ok := b.contexts[id]`
`341`	`341`	`b.contextsMu.RUnlock()`
`@@ -374,6 +374,7 @@ func (b Browser) newPageInContext(id cdp.BrowserContextID) (page Page, err err`
`374`	`374`	`}`
`375`	`375`	`// let the event handler know about the new page.`
`376`	`376`	`targetID <- tid`
	`377`	`+ var page *Page`
`377`	`378`	`select {`
`378`	`379`	`case <-waitForPage:`
`379`	`380`	`b.logger.Debugf("Browser:newPageInContext:<-waitForPage", "tid:%v bctxid:%v", tid, id)`