feat: enable racing in the querytee #20156
Merged
+193
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
reviewed
Dec 8, 2025
DylanGuedes
reviewed
Dec 8, 2025
Contributor
DylanGuedes
left a comment
DylanGuedes
left a comment
There was a problem hiding this comment.
just to small questions/nitpick suggestions
Comment on lines
6
to
7
| ADD COLUMN cell_a_won BOOLEAN NOT NULL DEFAULT FALSE, | ||
| ADD COLUMN cell_b_won BOOLEAN NOT NULL DEFAULT FALSE; |
Contributor
There was a problem hiding this comment.
question: in other parts of the code you used a single bool to infer which cell won, couldn't you take the same approach here?
Contributor
Author
There was a problem hiding this comment.
removed all of this as we already have exec time as robert mentioned here
rfratto
reviewed
Dec 8, 2025
Member
rfratto
left a comment
rfratto
left a comment
There was a problem hiding this comment.
LGTM, but probably needs real approval from Dylan or Trevor since they know this code better
pkg/goldfish/migrations/20251205000001_add_race_winner_columns.sql
Outdated
Show resolved
Hide resolved
This reverts commit f319c40.
ashwanthgoli
force-pushed
the
query-tee-racing
branch
from
4f516cc to
2671329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables racing in the querytee, allowing us to serve the split from the engine that returned a result the fastest, instead of always returning the result from the preferred/v1 engine.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR