Improve error handling, fix warnings and bump version to 1.4.0

Author: gordon-matt

elFinder.NetCore.Web/Controllers/FileSystemController.cs

@@ -16,15 +16,24 @@ public async Task<IActionResult> Connector()
         }
         catch (Exception ex)
         {
+            // TODO: would be good to Sanitize Exception Message at least in production, can leak server file paths
             return Json(new { error = "Unable to process your request: " + ex.Message });
         }
     }
 
     [Route("thumb/{hash}")]
     public async Task<IActionResult> Thumbs(string hash)
     {
-        var connector = GetConnector();
-        return await connector.GetThumbnailAsync(HttpContext.Request, HttpContext.Response, hash);
+        try
+        {
+            var connector = GetConnector();
+            return await connector.GetThumbnailAsync(HttpContext.Request, HttpContext.Response, hash);
+        }
+        catch (Exception ex)
+        {
+            // TODO: would be good to Sanitize Exception Message at least in production, can leak server file paths
+            return Json(new { error = "Unable to process your request: " + ex.Message });
+        }
     }
 
     private Connector GetConnector()

elFinder.NetCore.Web/elFinder.NetCore.Web.csproj

@@ -9,7 +9,7 @@
     <PackageProjectUrl>https://github.com/gordon-matt/elFinder.NetCore</PackageProjectUrl>
     <PackageLicenseUrl>
     </PackageLicenseUrl>
-    <Version>1.3.6</Version>
+    <Version>1.4.0</Version>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
   <ItemGroup>

elFinder.NetCore/Connector.cs

@@ -163,8 +163,13 @@ protected async Task<IActionResult> ProcessCoreAsync(HttpRequest request)
 
                     if (encoding == "scheme")
                     {
-                        using var client = new WebClient();
-                        var data = await client.DownloadDataTaskAsync(new Uri(content));
+                        //TODO: It's worth noting that for optimal performance and resource management,
+                        //  HttpClient should not be instantiated for each request in a real-world application.
+                        //  Instead, it's typically best to create a single or few long-lived HttpClient instances and reuse
+                        //  them for all HTTP calls. This can be achieved through dependency injection or a static/singleton
+                        //  instance, depending on your application's architecture.
+                        using var client = new HttpClient();
+                        var data = await client.GetByteArrayAsync(new Uri(content));
                         return await driver.PutAsync(path, data);
                     }
                     else

elFinder.NetCore/Exceptions/FileTypeNotAllowedException.cs

@@ -1,6 +1,4 @@
-using System.Runtime.Serialization;
-
-namespace elFinder.NetCore.Exceptions;
+namespace elFinder.NetCore.Exceptions;
 
 public class FileTypeNotAllowedException : ApplicationException
 {
@@ -17,9 +15,4 @@ public FileTypeNotAllowedException(string message, Exception innerException)
         : base(message, innerException)
     {
     }
-
-    protected FileTypeNotAllowedException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
 }

elFinder.NetCore/Exceptions/InvalidPathException.cs

@@ -1,6 +1,4 @@
-using System.Runtime.Serialization;
-
-namespace elFinder.NetCore.Exceptions;
+namespace elFinder.NetCore.Exceptions;
 
 public class InvalidPathException : ApplicationException
 {
@@ -17,9 +15,4 @@ public InvalidPathException(string message, Exception innerException)
         : base(message, innerException)
     {
     }
-
-    protected InvalidPathException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
 }

elFinder.NetCore/elFinder.NetCore.csproj

@@ -6,7 +6,7 @@
     <NeutralLanguage>en-US</NeutralLanguage>
     <Description>elFinder ASP.NET Core backend</Description>
     <PackageProjectUrl>https://github.com/gordon-matt/elFinder.NetCore</PackageProjectUrl>
-    <Version>1.3.6</Version>
+    <Version>1.4.0</Version>
     <PackageLicenseUrl>
     </PackageLicenseUrl>
     <OutputType>Library</OutputType>