Implement Gemini code assist recommendations and fix pre-commit issues

Apply code quality improvements suggested by Gemini code assist:
- Enhanced error pattern matching with more specific message detection
- Smart dynamic fallback logic based on which model actually failed
- Centralized error handling to eliminate code duplication across 4 functions
- More robust exception handling with proper Google API types
- Fixed regex pattern security issue with proper end anchoring

Fix pre-commit validation issues:
- Remove unused variables and parameters in ModelErrorDialog
- Fix invalid JSON syntax in tsconfig files (remove comments)
- Maintain all functionality while improving code quality

All model validation tests continue to pass.

Author: ipbabble

.pre-commit-config.yaml

@@ -73,4 +73,4 @@ repos:
 
 # Global settings
 default_install_hook_types: [pre-commit]
-default_stages: [pre-commit]
+default_stages: [pre-commit]

backend/src/agent/graph.py

@@ -1,6 +1,7 @@
 import os
 
 from dotenv import load_dotenv
+from google.api_core import exceptions as google_exceptions
 from google.genai import Client
 from langchain_core.messages import AIMessage
 from langchain_core.runnables import RunnableConfig
@@ -39,6 +40,16 @@
 genai_client = Client(api_key=os.getenv("GEMINI_API_KEY"))
 
 
+def _handle_model_not_found(e: Exception, model_name: str):
+    """Checks for a model not found error and raises a specific ValueError."""
+    if isinstance(e, google_exceptions.NotFound) or (
+        "404" in str(e) and "models/" in str(e)
+    ):
+        error_msg = f"Model '{model_name}' not found. Please try a different model."
+        raise ValueError(error_msg) from e
+    raise e
+
+
 # Nodes
 def generate_query(state: OverallState, config: RunnableConfig) -> QueryGenerationState:
     """LangGraph node that generates search queries based on the User's question.
@@ -83,15 +94,7 @@ def generate_query(state: OverallState, config: RunnableConfig) -> QueryGenerati
         result = structured_llm.invoke(formatted_prompt)
         return {"search_query": result.query}
     except Exception as e:
-        # Check if this is a model not found error
-        if "404" in str(e) and "models/" in str(e):
-            # Return an error that the frontend can catch
-            error_msg = (
-                f"Model '{model_to_use}' not found. Please try a different model."
-            )
-            raise ValueError(error_msg) from e
-        # Re-raise other errors
-        raise
+        _handle_model_not_found(e, model_to_use)
 
 
 def continue_to_web_research(state: QueryGenerationState):
@@ -154,15 +157,7 @@ def web_research(state: WebSearchState, config: RunnableConfig) -> OverallState:
             "web_research_result": [modified_text],
         }
     except Exception as e:
-        # Check if this is a model not found error
-        if "404" in str(e) and "models/" in str(e):
-            # Return an error that the frontend can catch
-            error_msg = (
-                f"Model '{model_to_use}' not found. Please try a different model."
-            )
-            raise ValueError(error_msg) from e
-        # Re-raise other errors
-        raise
+        _handle_model_not_found(e, model_to_use)
 
 
 def reflection(state: OverallState, config: RunnableConfig) -> ReflectionState:
@@ -209,15 +204,7 @@ def reflection(state: OverallState, config: RunnableConfig) -> ReflectionState:
             "number_of_ran_queries": len(state["search_query"]),
         }
     except Exception as e:
-        # Check if this is a model not found error
-        if "404" in str(e) and "models/" in str(e):
-            # Return an error that the frontend can catch
-            error_msg = (
-                f"Model '{reasoning_model}' not found. Please try a different model."
-            )
-            raise ValueError(error_msg) from e
-        # Re-raise other errors
-        raise
+        _handle_model_not_found(e, reasoning_model)
 
 
 def evaluate_research(
@@ -305,15 +292,7 @@ def finalize_answer(state: OverallState, config: RunnableConfig):
             "sources_gathered": unique_sources,
         }
     except Exception as e:
-        # Check if this is a model not found error
-        if "404" in str(e) and "models/" in str(e):
-            # Return an error that the frontend can catch
-            error_msg = (
-                f"Model '{reasoning_model}' not found. Please try a different model."
-            )
-            raise ValueError(error_msg) from e
-        # Re-raise other errors
-        raise
+        _handle_model_not_found(e, reasoning_model)
 
 
 # Create our Agent Graph

backend/tests/test_model_validation.py

@@ -70,7 +70,7 @@ def test_backend_models_follow_naming_convention(self):
             )
 
             # Should follow gemini-X.Y-model pattern
-            assert re.match(r"^gemini-\d+\.\d+-(flash|pro)(-lite)?", model), (
+            assert re.match(r"^gemini-\d+\.\d+-(flash|pro)(-lite)?$", model), (
                 f"Model {model} doesn't follow expected naming pattern"
             )
 

frontend/.prettierignore

@@ -4,4 +4,4 @@ build/
 .next/
 coverage/
 *.min.js
-*.min.css
+*.min.css

frontend/src/App.tsx

@@ -74,9 +74,9 @@ export default function App() {
       }
     },
     onError: (error: any) => {
-      // Check if this is a model 404 error
-      if (error.message && error.message.includes("404") && error.message.includes("models/")) {
-        const modelMatch = error.message.match(/models\/([\w-]+)/);
+      // Check if this is a model not found error using more specific matching
+      if (error.message?.includes("not found. Please try a different model.")) {
+        const modelMatch = error.message.match(/Model '([\w.-]+)' not found/);
         if (modelMatch && lastSubmission) {
           const failedModel = modelMatch[1];
           setModelError({
@@ -256,7 +256,6 @@ export default function App() {
       <ModelErrorDialog
         isOpen={!!modelError}
         failedModel={modelError?.failedModel || ""}
-        errorMessage={modelError?.errorMessage || ""}
         onContinueWithFallback={handleModelErrorContinue}
         onRetryWithDifferent={handleModelErrorRetry}
         onClose={handleModelErrorClose}

frontend/src/components/ModelErrorDialog.tsx

@@ -5,7 +5,6 @@ import { AlertTriangle, Zap, Cpu, CheckCircle } from "lucide-react";
 interface ModelErrorDialogProps {
   isOpen: boolean;
   failedModel: string;
-  errorMessage: string;
   onContinueWithFallback: (fallbackModel: string, rememberChoice: boolean) => void;
   onRetryWithDifferent: (newModel: string, rememberChoice: boolean) => void;
   onClose: () => void;
@@ -14,16 +13,15 @@ interface ModelErrorDialogProps {
 export const ModelErrorDialog: React.FC<ModelErrorDialogProps> = ({
   isOpen,
   failedModel,
-  errorMessage,
   onContinueWithFallback,
   onRetryWithDifferent,
   onClose,
 }) => {
-  const [rememberChoice, setRememberChoice] = React.useState(false);
 
   if (!isOpen) return null;
 
-  const recommendedFallback = "gemini-2.0-flash";
+  const recommendedFallback =
+    failedModel === "gemini-2.0-flash" ? "gemini-2.5-flash" : "gemini-2.0-flash";
 
   return (
     <div className="fixed inset-0 bg-black/50 flex items-center justify-center z-50 p-4">

frontend/src/test/model-validation.test.tsx

@@ -92,8 +92,8 @@ describe("Model Error Handling", () => {
     const errorDialogPath = join(process.cwd(), "src", "components", "ModelErrorDialog.tsx");
     const source = readFileSync(errorDialogPath, "utf-8");
 
-    // Look for the recommended fallback model
-    const fallbackMatch = source.match(/recommendedFallback = "([^"]+)"/);
+    // Look for the dynamic fallback model logic
+    const fallbackMatch = source.match(/recommendedFallback =\s*\n?\s*failedModel === "([^"]+)"/);
     expect(fallbackMatch).toBeTruthy();
 
     if (fallbackMatch) {

frontend/tsconfig.json

@@ -10,14 +10,12 @@
     "paths": {
       "@/*": ["./src/*"]
     },
-    /* Bundler mode */
     "moduleResolution": "bundler",
     "allowImportingTsExtensions": true,
     "isolatedModules": true,
     "moduleDetection": "force",
     "noEmit": true,
     "jsx": "react-jsx",
-    /* Linting */
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,

frontend/tsconfig.node.json

@@ -6,14 +6,12 @@
     "module": "ESNext",
     "skipLibCheck": true,
 
-    /* Bundler mode */
     "moduleResolution": "bundler",
     "allowImportingTsExtensions": true,
     "isolatedModules": true,
     "moduleDetection": "force",
     "noEmit": true,
 
-    /* Linting */
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,

setup-precommit.sh

@@ -30,4 +30,4 @@ echo "✅ Pre-commit setup complete!"
 echo ""
 echo "Pre-commit hooks will now run automatically before each commit."
 echo "To run manually: pre-commit run --all-files"
-echo "To skip hooks (emergency only): git commit --no-verify"
+echo "To skip hooks (emergency only): git commit --no-verify"