Fix bug: Handle empty iterator in _print_stream function #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _print_stream function had a bug where if the iterator was empty (no states were yielded), the variable 'state' would be undefined when accessed outside the loop, causing a NameError. Changes: - Track the last state during iteration in a separate variable (last_state) - Add explicit check for empty iterator case and raise ValueError with clear message - Preserve existing code structure with assignment to 'out' variable before return This fixes a potential runtime error that could occur in edge cases where the streaming iterator yields no states, such as early termination before any states are produced. Location: gemma/gm/text/_chat_sampler.py lines 223-240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _print_stream function had a bug where if the iterator was empty (no states were yielded), the variable 'state' would be undefined when accessed outside the loop, causing a NameError.
Changes:
This fixes a potential runtime error that could occur in edge cases where the streaming iterator yields no states, such as early termination before any states are produced.
Location: gemma/gm/text/_chat_sampler.py lines 223-240