Skip to content

SAVEPOINT LEVEL1 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexrett opened this issue Jun 7, 2019 · 9 comments
Open

SAVEPOINT LEVEL1 #393

alexrett opened this issue Jun 7, 2019 · 9 comments

Comments

@alexrett
Copy link

alexrett commented Jun 7, 2019

This commit breaks parsing some log queries
35983ce

For example:

[2019/06/07 15:38:48] [info] sync.go:71 rotate binlog to (binary_log.049500, 471293950)
2019/06/07 15:38:48 line 1 column 9 near "SAVEPOINT `LEVEL1`" 
[2019/06/07 15:38:48] [error] sync.go:121 parse query(SAVEPOINT `LEVEL1`) err line 1 column 9 near "SAVEPOINT `LEVEL1`" 
[2019/06/07 15:38:48] [error] canal.go:230 canal start sync binlog err: line 1 column 9 near "SAVEPOINT `LEVEL1`" 

On the previous version everything fine

@siddontang
Copy link
Collaborator

oh, seem the parser doesn't support SAVEPOINT, we should let it support at first.

PTAL @GregoryIan

@siddontang
Copy link
Collaborator

maybe at first, we can ignore this error?

@IANTHEREAL
Copy link
Collaborator

agree with you @siddontang, how about filter the statements not supported by the parser and actually does not need to be parsed here?

@siddontang
Copy link
Collaborator

yes, we can do it at first.

@IANTHEREAL
Copy link
Collaborator

IANTHEREAL commented Jun 17, 2019

@WangXiangUSTC can you help it?

@WangXiangUSTC
Copy link
Contributor

ok,I will fix this issue

@WangXiangUSTC
Copy link
Contributor

fixed in #394

@ansonhorse
Copy link

@siddontang @WangXiangUSTC Could you tell me how to solve it? Thanks!

[2020/08/05 21:15:50] [info] dump.go:180 skip dump, use last binlog replication pos (mysql-bin.004945, 458157170) or GTID set <nil>
[2020/08/05 21:15:50] [info] binlogsyncer.go:362 begin to sync binlog from position (mysql-bin.004945, 458157170)
[2020/08/05 21:15:50] [info] binlogsyncer.go:211 register slave for master server xxxx:3306
[2020/08/05 21:15:50] [info] sync.go:25 start sync binlog at binlog file (mysql-bin.004945, 458157170)
[2020/08/05 21:15:50] [info] binlogsyncer.go:731 rotate to (mysql-bin.004945, 458157170)
[2020/08/05 21:15:50] [info] sync.go:71 rotate binlog to (mysql-bin.004945, 458157170)
[2020/08/05 21:15:50] [info] master.go:54 save position (mysql-bin.004945, 458157170)
[2020/08/05 21:15:50] [error] sync.go:121 parse query(SAVEPOINT `LEVEL1`) err line 1 column 9 near "SAVEPOINT `LEVEL1`"
[2020/08/05 21:15:50] [error] canal.go:230 canal start sync binlog err: line 1 column 9 near "SAVEPOINT `LEVEL1`"
[2020/08/05 21:15:50] [error] river.go:297 start canal err line 1 column 9 near "SAVEPOINT `LEVEL1`"

@ansonhorse
Copy link

Sorry, problem above happens in go-mysql-elasticsearch, go-mysql-org/go-mysql-elasticsearch#375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants