Skip to content

Expose route issues to the user #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfschwarz opened this issue Apr 13, 2025 · 2 comments
Open

Expose route issues to the user #1369

jfschwarz opened this issue Apr 13, 2025 · 2 comments

Comments

@jfschwarz
Copy link
Collaborator

jfschwarz commented Apr 13, 2025

Look at the following submit page, which is crashing due to an error in the account setup:

Sign page

The error here is:

Cannot use MultiSendCallOnly for a batch with DelegateCall transactions

This indicates that the account is not configured to allow such calls. Instead of crashing the page we should transparently show the issue to the user so they can figure the issue out on their own rather than assuming Pilot is broken.

@frontendphil Maybe we should simply keep the full error details open even in prod?

@frontendphil
Copy link
Member

@jfschwarz, we can do that. I got trained not to do it because that freaked out people even more in the contexts I've worked in before. However, everything is different in the crypto world :D

Alternatively, do you think there is a good way to detect these kinds of errors and distinguish them from actual application errors? Then we could show them in a bit of a more friendly way.

@jfschwarz
Copy link
Collaborator Author

A more friendly error would be even better, but I think there's a number of root causes for route issues and trying to handle them all is ambitious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants