fix: Extension is not switched to new account after creating it #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
juliopavila
changed the title
Landing page preview |
Comment on lines
+39
to
+41
| } else { | ||
| navigate(`/${activeRouteId}/clear-transactions/${routeId}`) | ||
| } |
There was a problem hiding this comment.
This case should never happen. This would mean we're clearing transactions without the consent of the user. However, if we reach this point of the code, we can keep all transactions even if we switch the route because the target safe stays the same, or there are no transactions to clear. So navigate(/${routeId})` is the only viable option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #1348
This PR addresses a persistent UX issue described in #1348, where the extension would not switch to the newly created account after the user completed the creation flow.
Context
The problem was caused by missing handling in
useLaunchRoutefor the case where a new route is created (i.e. therouteIddiffers from the currentactiveRouteId). While theonLaunchcallback was invoked, no navigation was triggered, leaving the extension and UI in an inconsistent state.Changes
useLaunchRouteto differentiate between updating an existing account vs. creating a new one.onLaunchcallback (as before),