Skip to content

Commit ab6e1dd

Browse files
committed
Fixed documentation formatting for shape families from #177
1 parent 05211f5 commit ab6e1dd

File tree

2 files changed

+23
-6
lines changed

2 files changed

+23
-6
lines changed

coxeter/families/common.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def make_vertices(cls, n):
7575
PlatonicFamily = TabulatedGSDShapeFamily.from_json_file(
7676
os.path.join(_DATA_FOLDER, "platonic.json"),
7777
classname="PlatonicFamily",
78-
docstring="""The family of Platonic solids.
78+
docstring="""The family of Platonic solids (5 total).
7979
8080
The following parameters are required by this class:
8181
@@ -88,6 +88,7 @@ def make_vertices(cls, n):
8888
os.path.join(_DATA_FOLDER, "archimedean.json"),
8989
classname="ArchimedeanFamily",
9090
docstring="""The family of Archimedean solids (13 total).
91+
9192
The following parameters are required by this class:
9293
- name: The name of the ArchimedeanFamily solid. Options are "Cuboctahedron", \
9394
"Icosidodecahedron", "Truncated Tetrahedron", "Truncated Octahedron", \
@@ -101,8 +102,9 @@ def make_vertices(cls, n):
101102
CatalanFamily = TabulatedGSDShapeFamily.from_json_file(
102103
os.path.join(_DATA_FOLDER, "catalan.json"),
103104
classname="CatalanFamily",
104-
docstring="""The family of Catalan solids, also known as Archimedean duals
105+
docstring="""The family of Catalan solids, also known as Archimedean duals \
105106
(13 total).
107+
106108
The following parameters are required by this class:
107109
- name: The name of the CatalanFamily solid. Options are "Deltoidal \
108110
Hexecontahedron", "Deltoidal Icositetrahedron", "Disdyakis \
@@ -117,10 +119,12 @@ def make_vertices(cls, n):
117119
JohnsonFamily = TabulatedGSDShapeFamily.from_json_file(
118120
os.path.join(_DATA_FOLDER, "johnson.json"),
119121
classname="JohnsonFamily",
120-
docstring="""The family of Johnson solids (92 total).
122+
docstring="""The family of Johnson solids, as enumerated in \
123+
:cite:`Johnson1966` (92 total).
124+
121125
The following parameters are required by this class:
122126
- name: The name of the JohnsonFamily solid. A full list is available in \
123-
10.1126/science.1220869: :cite:`Damasceno2012`. In general, shape names \
127+
:cite:`Johnson1966`. In general, shape names \
124128
should have the first character of each word capitalized, with spaces \
125129
between words (e.g. "Elongated Triangular Cupola"). Pyramids and \
126130
dipyramids are named from their base polygon (e.g. "Square Pyramid" \
@@ -133,7 +137,8 @@ def make_vertices(cls, n):
133137
os.path.join(_DATA_FOLDER, "pyramid_dipyramid.json"),
134138
classname="PyramidDipyramidFamily",
135139
docstring="""The family of regular equilateral pyramids and dipyramids (6 total).
136-
The following parameters are required by this class:
140+
141+
The following parameters are required by this class:
137142
- name: The name of the pyramid or dipyramid. Options are "Triangular Pyramid", \
138143
"Square Pyramid", "Pentagonal Pyramid", "Triangular Dipyramid", \
139144
"Square Dipyramid", and "Pentagonal Dipyramid".
@@ -144,7 +149,8 @@ def make_vertices(cls, n):
144149
os.path.join(_DATA_FOLDER, "prism_antiprism.json"),
145150
classname="PrismAntiprismFamily",
146151
docstring="""The family of n-gonal prisms and antiprisms with n∈[3,10] (16 total).
147-
The following parameters are required by this class:
152+
153+
The following parameters are required by this class:
148154
- name: The name of the prism or antiprism. Options for prisms are \
149155
"Triangular Prism", "Square Prism", "Pentagonal Prism", "Hexagonal Prism", \
150156
"Heptagonal Prism", "Octagonal Prism", "Nonagonal Prism", and \

doc/source/coxeter.bib

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,17 @@ @article{Chen2014
5050
doi = {10.1103/PhysRevX.4.011024},
5151
}
5252

53+
@article{Johnson1966,
54+
title={Convex Polyhedra with Regular Faces},
55+
author={Johnson, Norman W.},
56+
journal={Canadian Journal of Mathematics},
57+
volume={18},
58+
pages={169–200},
59+
year={1966},
60+
publisher={Cambridge University Press},
61+
doi={10.4153/cjm-1966-021-8},
62+
}
63+
5364
@article{Damasceno2012,
5465
author = {Damasceno, Pablo F. and Engel, Michael and Glotzer, Sharon C.},
5566
title = {Crystalline Assemblies and Densest Packings of a Family of Truncated Tetrahedra and the Role of Directional Entropic Forces},

0 commit comments

Comments
 (0)