Skip to content

Commit highlighting when in whole file blame should follow selection instead of just the cursor #1712

@justinTM

Description

@justinTM
  • GitLens Version: v11.6.1
  • Git Version: git version 2.32.0
  • VSCode Version: 1.61.2
  • OS Version: macOS 10.15.7 (19H1419)

Steps to Reproduce:

1. Click File Annotations button 

2. Click Toggle File Blame option

3. select multiple lines using either of the below methods:
    
    a. within the Editor, select multiple lines
        1. I use Cmd+Click, or Select All Occurrences of Match (Cmd+Shift+L)
    
    b. within the annotations gutter,  select multiple commits
        1. Cmd+Click on commits in gutter
        2. Shift+Click on commits in gutter

Basically the current state shows incorrect information about commits associated with selected lines. A visual example would be when highlighting multiple lines in the editor; although multiple commits belong to this selection, Git Lens decorates only a subset of the correct commits. Screenshot below.

image

@eamodio I saw your work in updateBlame() for this issue: https://github.com/Axosoft/vscode-gitlens/issues/new?assignees=&labels=potential-bug%2C+triage&template=bug_report.md&title=

I'm going to investigate if I can connect the File Blame annotations gutter with that multi-line selection code you added a while back.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions