Skip to content

Provide extensions for supporting a custom proxy client #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
decyjphr opened this issue Oct 19, 2022 · 3 comments · Fixed by #807
Closed

Provide extensions for supporting a custom proxy client #316

decyjphr opened this issue Oct 19, 2022 · 3 comments · Fixed by #807
Labels
enhancement New feature or request

Comments

@decyjphr
Copy link
Collaborator

Prerequisites:

  • Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature. No

New Feature

Octokit client that Probot uses does not support proxy settings. See documentation

App needs to provide extensions for situations where the app will be running in an environment that is behind an outbound proxy
@decyjphr decyjphr added the enhancement New feature or request label Oct 19, 2022
@aimeegee
Copy link

aimeegee commented Aug 8, 2024

Hi @decyjphr, just wonder is there any update on this issue? Or any suggested workaround?

@decyjphr
Copy link
Collaborator Author

decyjphr commented Aug 8, 2024

Probot can be started programmatically and you can provide custom Octokit options. One of those could be to use a Request that uses a ProxyAgent

You can try something like

run(app, {
  Octokit: {
  request: {
    agent: new ProxyAgent()
  }
},
  log: pino(),
});

Personally, I haven't tried this , but I hope this helps.

@decyjphr
Copy link
Collaborator Author

decyjphr commented Apr 6, 2025

Taking this up.
Will first add proxy support for lambda since that handler method provide an easy way to modify probot. Then will extend that to the standalone app.

@decyjphr decyjphr mentioned this issue Apr 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add proxy support for aws lambda github/safe-settings
2 participants
@decyjphr @aimeegee