Add Tool Name property for List Code Scanning Alerts tool #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-Rinker
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request adds an optional tool_name parameter to the ListCodeScanningAlerts function to allow specifying the tool used for code scanning and updates the corresponding tests and documentation.
- Introduces tool_name parameter in code_scanning.go
- Updates tests in code_scanning_test.go to assert the new parameter
- Enhances documentation in README.md to include tool_name
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/code_scanning_test.go | Adds assertions and test cases for the newly added tool_name property in input schema. |
| pkg/github/code_scanning.go | Introduces and passes the optional tool_name parameter to the GitHub client API call. |
| README.md | Updates the documentation to include the tool_name parameter description. |
SamMorrowDrums
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new optional parameter,
tool_name, to theListCodeScanningAlertsfunction and updates the relevant documentation and tests accordingly.Closes: #271