Skip to content

Enrich tool properties with additional checks/constraints #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tonytrg opened this issue Apr 11, 2025 · 2 comments
Closed

Enrich tool properties with additional checks/constraints #228

tonytrg opened this issue Apr 11, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@tonytrg
Copy link
Contributor

tonytrg commented Apr 11, 2025

Describe the feature or problem you’d like to solve

The mcp libraries allow more fine grained control for the tool props. It would be worth it to evaluate the performance improvements for the tool props with checks/constraints.

Proposed solution

Improve property handling of mcp with tooling functions like the enum check from mark3labs.

Additional context

Example with enums #227

@tonytrg tonytrg added the enhancement New feature or request label Apr 11, 2025
@SamMorrowDrums
Copy link
Collaborator

This is how we are moving forward. There are a bunch of enums in the codebase already, so I think this issue can be closed, unless you want to change it to track a specific list of missing ones?

As it stands, we are actively trying to utilise this feature in any new work where applicable and are in full agreement with the intent of this issue, so I don't believe it needs to be tracked explicitly.

Thank you for this. Any PR fixing such oversights are welcome.🙏

@tonytrg
Copy link
Contributor Author

tonytrg commented Apr 14, 2025

@SamMorrowDrums
Alright 👍

Just trying to move away from private conversations and keep such discussions public :)
I will follow up with the pr once I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants