Skip to content

Commit f4057eb

Browse files
authored
Remove unnecessary hardcoding of ref (#1456)
I'm copying the setup of one of these actions to another repo, and the hardcoding of ref surprised me... these should be the same as the defaault behavior. I checked with Barry who originally committed these files, and he didn't remember why... possibly he'd hardcoded them when testing the action and forgot to remove them. So let's pull them out to remove confusion.
1 parent 930c7b1 commit f4057eb

File tree

4 files changed

+0
-10
lines changed

4 files changed

+0
-10
lines changed

Diff for: .github/workflows/check-dist.yml

-4
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ jobs:
1313

1414
steps:
1515
- uses: actions/checkout@v4
16-
with:
17-
ref: ${{ github.event.pull_request.head.sha }}
1816

1917
- name: Setup Node.js
2018
uses: actions/setup-node@v4
@@ -33,8 +31,6 @@ jobs:
3331
runs-on: ubuntu-latest
3432
steps:
3533
- uses: actions/checkout@v4
36-
with:
37-
ref: ${{ github.event.pull_request.head.sha }}
3834

3935
- uses: ./
4036
with:

Diff for: .github/workflows/codeql-analysis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ jobs:
2424

2525
steps:
2626
- uses: actions/checkout@v4
27-
with:
28-
ref: ${{ github.event.pull_request.head.sha }}
2927

3028
- name: Initialize CodeQL
3129
uses: github/codeql-action/init@v3

Diff for: .github/workflows/integration-test.yml

-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v4
17-
with:
18-
ref: ${{ github.event.pull_request.head.sha }}
1917

2018
- name: Setup Node.js
2119
uses: actions/setup-node@v4

Diff for: .github/workflows/test.yml

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v4
15-
with:
16-
ref: ${{ github.event.pull_request.head.sha }}
1715

1816
- name: Setup Node.js
1917
uses: actions/setup-node@v4

0 commit comments

Comments
 (0)