-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rust: Path resolution before variable resolution #20716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hvitved
wants to merge
2
commits into
github:main
Choose a base branch
from
hvitved:rust/path-resolution-variable-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+714
−393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f41c74b to
fa48969
Compare
b74d8c6 to
e845ff0
Compare
530a7a8 to
5410d17
Compare
rust/ql/lib/codeql/rust/elements/internal/FormatTemplateVariableAccessImpl.qll
Fixed
Show fixed
Hide fixed
07703ae to
fbb1541
Compare
fbb1541 to
da174c3
Compare
da174c3 to
ec3b2c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-change-note-required
This PR does not need a change note
Rust
Pull requests that update Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path resolution needs to happen before variable resolution, because otherwise we cannot know whether an identifier pattern binds a new variable or whether it refers to a constructor or constant:
Even though variable names typically start with a lowercase letter and constructors/constants with an uppercase letter, this is not enforced by the Rust language.
Variables may shadow declarations, so variable resolution also needs to affect path resolution:
So it may seem that path resolution and variable resolution must happen in mutual recursion, but we would like to keep the inherently global path resolution logic separate from the inherently local variable resolution logic. We acheive this by
resolvePathIgnoreVariableShadowing.resolvePathIgnoreVariableShadowingis sufficient to determine whether an identifier pattern resolves to a constructor/constant, since if it does, it cannot be shadowed by a variable. We expose this as the predicateidentPatIsResolvable.identPatIsResolvable.resolvePathIgnoreVariableShadowingto paths that are not resolvable via variable resolution.