Upgrade github/codeql dependency to 2.20.7
#913
+290
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Update queries after `TemplateParameter` deprecation
Update A2-10-4 after QL changes
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
|
Seems like a fairly large performance regression. I am happy to take a look at the compatible types predicate and the integer constant macro predicate performance. |
30 tasks
…nteger constant macros
…es-upgrading-to-2.20.7 Fix bad joins on function names and unnecessarily large relation on integer constant macros
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
|
Still a fair performance regression in cpp, from 2837 to 3299 seconds. That ~450 sec delay is not entirely explained by the slowest predicates highlighted:
Totals to 289s by themselves alone, ignoring that they really need to be compared to the slowest predicates from the previous release. We'll need to rely on the data pushed up to the release engineering branch and expect maybe a few rounds of getting this down. |
Poor join ordering on locations.
- Only consider declarations within user code - as results in system headers will be thrown away, and significantly bloat the interemediate relation sizes. - Inline the function scope exclusion to documentable declaration. - Extract utility predicates for determining if there's a documented definition, or whether there are only definitions.
Avoid cross-product on function.
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
|
@MichaelRFairhurst I've made some further performance improvements, and it looks like we've now addressed the main issues - performance for both C and C++ is now below the 2.48.0 release. |
MichaelRFairhurst
requested changes
Jul 18, 2025
|
|
||
| query predicate problems(FunctionCall fc, string message, RecursiveFunction f, string functionName) { | ||
| not isExcluded(fc, getQuery()) and | ||
| f = fc.getTarget() and |
There was a problem hiding this comment.
This query is incorrect, I think.
Filed here: #935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the CodeQL CLI version to 2.20.7.
CodeQL dependency upgrade checklist:
github/codeqltest cases succeed.github/codeql-coding-standardsrepository.