chore(ci): Remove Package.swift checks (#6110)

Author: itaybre

.github/file-filters.yml

@@ -371,17 +371,6 @@ run_testflight_for_pushes: &run_testflight_for_pushes
   - "fastlane/**"
   - "Makefile"
 
-run_check_package_diff_for_prs: &run_check_package_diff_for_prs
-  - ".github/workflows/check-package-diff.yml"
-  - ".github/file-filters.yml"
-
-  # Package files
-  - "Package*.swift"
-
-  # Build configuration
-  - "Makefile"
-  - "Utils/expected_package_diff.patch"
-
 run_codeql_analysis_for_prs: &run_codeql_analysis_for_prs
   - "Sources/**"
 

.github/workflows/check-package-diff.yml

@@ -129,7 +129,7 @@ jobs:
   # the github.sha is be the pre merge commit id for PRs.
   # See https://github.community/t/github-sha-isnt-the-value-expected/17903/17906.
   validate-spm:
-    name: Validate SPM Static ${{matrix.package-file.name}}
+    name: Validate SPM Static
     runs-on: macos-14
     needs: [files-changed, assemble-xcframework-variant]
     # Run the job only for PRs with related changes or non-PR events.
@@ -144,20 +144,14 @@ jobs:
         uses: ./.github/actions/prepare-package.swift
         with:
           is-pr: ${{ github.event_name == 'pull_request' }}
-          package-file: ${{matrix.package-file.name}}
       - run: swift build
         working-directory: Samples/macOS-SPM-CommandLine
       - name: Run CI Diagnostics
         if: failure()
         run: ./scripts/ci-diagnostics.sh
-    strategy:
-      matrix:
-        package-file:
-          - name: Package.swift
-          - name: [email protected]
 
   validate-spm-dynamic:
-    name: Validate SPM Dynamic ${{matrix.package-file.name}}
+    name: Validate SPM Dynamic
     runs-on: macos-14
     needs: [files-changed, assemble-xcframework-variant]
     # Run the job only for PRs with related changes or non-PR events.
@@ -172,20 +166,14 @@ jobs:
         uses: ./.github/actions/prepare-package.swift
         with:
           is-pr: ${{ github.event_name == 'pull_request' }}
-          package-file: ${{matrix.package-file.name}}
       - run: swift build
         working-directory: Samples/SPM-Dynamic
       - name: Run CI Diagnostics
         if: failure()
         run: ./scripts/ci-diagnostics.sh
-    strategy:
-      matrix:
-        package-file:
-          - name: Package.swift
-          - name: [email protected]
 
   swift-build:
-    name: Build Swift Static ${{matrix.package-file.name}}
+    name: Build Swift Static
     runs-on: macos-14
     needs: [files-changed, assemble-xcframework-variant]
     # Run the job only for PRs with related changes or non-PR events.
@@ -200,16 +188,10 @@ jobs:
         uses: ./.github/actions/prepare-package.swift
         with:
           is-pr: ${{ github.event_name == 'pull_request' }}
-          package-file: ${{matrix.package-file.name}}
       - run: swift build
       - name: Run CI Diagnostics
         if: failure()
         run: ./scripts/ci-diagnostics.sh
-    strategy:
-      matrix:
-        package-file:
-          - name: Package.swift
-          - name: [email protected]
 
   validate-spm-visionos:
     name: Validate SPM Static visionOS
@@ -227,7 +209,6 @@ jobs:
         uses: ./.github/actions/prepare-package.swift
         with:
           is-pr: ${{ github.event_name == 'pull_request' }}
-          package-file: [email protected]
       - run: set -o pipefail &&xcodebuild build -scheme visionOS-SPM -sdk xros -destination 'generic/platform=xros' | tee raw-build-output-spm-visionOS.log | xcbeautify
         working-directory: Samples/visionOS-SPM
       - name: Run CI Diagnostics

.github/workflows/release.yml

@@ -189,18 +189,3 @@ xcode-ci:
 	xcodegen --spec Samples/watchOS-Swift/watchOS-Swift.yml
 	xcodegen --spec TestSamples/SwiftUITestSample/SwiftUITestSample.yml
 	xcodegen --spec TestSamples/SwiftUICrashTest/SwiftUICrashTest.yml
-
-.PHONY: check-package-diff update-package-diff
-# Diff will return an error if the files are different, so we need to ignore it with `|| true`.
-check-package-diff:
-	diff Package.swift [email protected] > current_package_diff.patch || true
-	@if diff ./Utils/expected_package_diff.patch current_package_diff.patch > /dev/null 2>&1; then \
-		echo "--> Package diff check passed - no changes detected"; \
-	else \
-		echo "--> Package diff check failed - changes detected! Make sure to run \"make update-package-diff\" to update the expected diff."; \
-		exit 1; \
-	fi
-
-# Diff will return an error if the files are different, so we need to ignore it with `|| true`.
-update-package-diff:
-	diff Package.swift [email protected] > ./Utils/expected_package_diff.patch || true

Makefile

@@ -39,7 +39,6 @@ let fromVersionFile = "./Sentry.podspec"
 let files = [
     "./Sentry.podspec",
     "./Package.swift",
-    "./[email protected]",
     "./SentryPrivate.podspec",
     "./SentrySwiftUI.podspec",
     "./Sources/Sentry/SentryMeta.m",