Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Commit 5abf76a

Browse files
authored
Update requests.mdx (#1332)
1 parent bf34a3b commit 5abf76a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/docs/sdk/performance/modules/requests.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ The SDK should auto-instrument all outgoing HTTP requests, regardless of the lib
99
| Attribute | Description | Notes |
1010
|:--|:--|:--|
1111
| `op` | Always `"http.client"` | Required |
12-
| `description` | A string including the HTTP request method, and the full URL. e.g., `"GET https://example.com/data.json"` | Required [^1] |
12+
| `description` | A string including the HTTP request method, and the partial URL. e.g., `"GET https://example.com/data.json"` | Required [^1] |
1313
| `data` | A key-value mapping of span attributes. (e.g., `{"http.query": "filter=all", "server.address": "prod-2.example.com"}`) | Required for full experience. See [Span Data](#span-data) for details |
1414

1515
### Span Data
1616

1717
None of the span data fields are hard requirements, but attaching as many of them as possible is a more future-proof approach. We recommend that the SDK adds every attribute listed in the [HTTP Span Data Conventions](/sdk/performance/span-data-conventions/#http). The minimal requirements are:
1818

19-
- `server.address` must be set to allow correct domain grouping _for descriptions containing relative URLs_. e.g., the description `"GET /data.json"` is missing a domain. In this case, `server.address` must be set. If the span description contains the full URL, `span.server` can be omitted
19+
- `server.address` must be set to allow correct domain grouping _for descriptions containing relative URLs_. e.g., the description `"GET /data.json"` is missing a domain. In this case, `server.address` must be set. If the span description contains the partial URL, `span.server` can be omitted
2020
- `http.response.status_code` must be set to enable response code breakdowns
2121

2222
## Instrumentation Example

0 commit comments

Comments
 (0)