[GEP-31] Introduce Constants needed for Conditons and Status for InPlace update (#980) (#983)

* Introduce Constants needed for Conditons and Status




* Address PR review feedback

---------

Co-authored-by: Ashish Ranjan Yadav <[email protected]>
Co-authored-by: Sonu Kumar Singh <[email protected]>
Co-authored-by: Shafeeque E S <[email protected]>

Author: 4 people

pkg/apis/machine/types.go

@@ -221,6 +221,15 @@ const (
 
 	// MachineCrashLoopBackOff means creation or deletion of the machine is failing. It means that machine object is present but there is no corresponding VM.
 	MachineCrashLoopBackOff MachinePhase = "CrashLoopBackOff"
+
+	// MachineInPlaceUpdating means machine is being updated in-place
+	MachineInPlaceUpdating MachinePhase = "InPlaceUpdating"
+
+	// MachineInPlaceUpdateSuccessful means machine in-place update was successful
+	MachineInPlaceUpdateSuccessful MachinePhase = "InPlaceUpdateSuccessful"
+
+	// MachineInPlaceUpdateFailed means machine in-place update failed
+	MachineInPlaceUpdateFailed MachinePhase = "InPlaceUpdateFailed"
 )
 
 // MachineState is a label for the state of a machines at the current time.
@@ -249,6 +258,12 @@ const (
 	// MachineOperationUpdate indicates that the operation was an update
 	MachineOperationUpdate MachineOperationType = "Update"
 
+	// MachineOperationInPlaceUpdate indicates that the operation was an in-place update
+	MachineOperationInPlaceUpdate MachineOperationType = "InPlaceUpdate"
+
+	// MachineOperationDrainNode indicates that the operation was a drain node
+	MachineOperationDrainNode MachineOperationType = "DrainNode"
+
 	// MachineOperationHealthCheck indicates that the operation was a create
 	MachineOperationHealthCheck MachineOperationType = "HealthCheck"
 
@@ -271,6 +286,29 @@ const (
 	ConditionUnknown ConditionStatus = "Unknown"
 )
 
+const (
+	// NodeInPlaceUpdate is a node condition type for in-place update
+	NodeInPlaceUpdate corev1.NodeConditionType = "InPlaceUpdate"
+
+	// CandidateForUpdate is a constant for reason in condition that indicates node is candidate for update
+	CandidateForUpdate string = "CandidateForUpdate"
+
+	// SelectedForUpdate is a constant for reason in condition that indicates node is selected for update
+	SelectedForUpdate string = "SelectedForUpdate"
+
+	// DrainSuccessful is a constant for reason in condition that indicates node drain is successful
+	DrainSuccessful string = "DrainSuccessful"
+
+	// ReadyForUpdate is a constant for reason in condition that indicates node is ready for update
+	ReadyForUpdate string = "ReadyForUpdate"
+
+	// UpdateSuccessful is a constant for reason in condition that indicates update succeeded
+	UpdateSuccessful string = "UpdateSuccessful"
+
+	// UpdateFailed is a constant for reason in condition that indicates update failed
+	UpdateFailed string = "UpdateFailed"
+)
+
 /********************** MachineSet APIs ***************/
 
 // +genclient

pkg/apis/machine/v1alpha1/machine_types.go

@@ -151,6 +151,15 @@ const (
 
 	// MachineCrashLoopBackOff means machine creation is failing. It means that machine object is present but there is no corresponding VM.
 	MachineCrashLoopBackOff MachinePhase = "CrashLoopBackOff"
+
+	// MachineInPlaceUpdating means machine is being updated in-place
+	MachineInPlaceUpdating MachinePhase = "InPlaceUpdating"
+
+	// MachineInPlaceUpdateSuccessful means machine in-place update was successful
+	MachineInPlaceUpdateSuccessful MachinePhase = "InPlaceUpdateSuccessful"
+
+	// MachineInPlaceUpdateFailed means machine in-place update failed
+	MachineInPlaceUpdateFailed MachinePhase = "InPlaceUpdateFailed"
 )
 
 // MachineState is a current state of the operation.
@@ -179,6 +188,12 @@ const (
 	// MachineOperationUpdate indicates that the operation was an update
 	MachineOperationUpdate MachineOperationType = "Update"
 
+	// MachineOperationInPlaceUpdate indicates that the operation was an in-place update
+	MachineOperationInPlaceUpdate MachineOperationType = "InPlaceUpdate"
+
+	// MachineOperationDrainNode indicates that the operation was a drain node
+	MachineOperationDrainNode MachineOperationType = "DrainNode"
+
 	// MachineOperationHealthCheck indicates that the operation was a health check of node object
 	MachineOperationHealthCheck MachineOperationType = "HealthCheck"
 
@@ -201,6 +216,29 @@ const (
 	ConditionUnknown ConditionStatus = "Unknown"
 )
 
+const (
+	// NodeInPlaceUpdate is a node condition type for in-place update
+	NodeInPlaceUpdate corev1.NodeConditionType = "InPlaceUpdate"
+
+	// CandidateForUpdate is a constant for reason in condition that indicates node is candidate for update
+	CandidateForUpdate string = "CandidateForUpdate"
+
+	// SelectedForUpdate is a constant for reason in condition that indicates node is selected for update
+	SelectedForUpdate string = "SelectedForUpdate"
+
+	// ReadyForUpdate is a constant for reason in condition that indicates node is ready for update
+	ReadyForUpdate string = "ReadyForUpdate"
+
+	// DrainSuccessful is a constant for reason in condition that indicates node drain is successful
+	DrainSuccessful string = "DrainSuccessful"
+
+	// UpdateSuccessful is a constant for reason in condition that indicates update succeeded
+	UpdateSuccessful string = "UpdateSuccessful"
+
+	// UpdateFailed is a constant for reason in condition that indicates update failed
+	UpdateFailed string = "UpdateFailed"
+)
+
 // CurrentStatus contains information about the current status of Machine.
 type CurrentStatus struct {
 	Phase MachinePhase `json:"phase,omitempty"`

pkg/util/provider/machineutils/utils.go

@@ -23,6 +23,9 @@ const (
 	// InitiateDrain specifies next step as initiate node drain
 	InitiateDrain = "Initiate node drain"
 
+	// NodeReadyForUpdate specifies next step as node ready for update.
+	NodeReadyForUpdate = "Node drain successful. Node is ready for update"
+
 	// DelVolumesAttachments specifies next step as deleting volume attachments
 	DelVolumesAttachments = "Delete Volume Attachments"