Skip to content

[PR] Update flake8 requirement from ~=4.0.1 to ~=6.1.0 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohl-bot opened this issue Apr 6, 2025 · 2 comments
Closed

[PR] Update flake8 requirement from ~=4.0.1 to ~=6.1.0 #61

ohl-bot opened this issue Apr 6, 2025 · 2 comments

Comments

@ohl-bot
Copy link
Collaborator

ohl-bot commented Apr 6, 2025

Pull Request originally created by dependabot[bot] on 2023-08-21T11:15:13Z

Merging: dependabot/pip/flake8-approx-eq-6.1.0 @ fa17fb8286c7a9d801e07f8f28dfabb79b74f287

To base branch: main @ 0480f3f


Updates the requirements on flake8 to permit the latest version.

Commits

You can trigger a rebase of this PR by commenting [dependabot](https://github.com/dependabot) rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • [dependabot](https://github.com/dependabot) rebase will rebase this PR
  • [dependabot](https://github.com/dependabot) recreate will recreate this PR, overwriting any edits that have been made to it
  • [dependabot](https://github.com/dependabot) merge will merge this PR after your CI passes on it
  • [dependabot](https://github.com/dependabot) squash and merge will squash and merge this PR after your CI passes on it
  • [dependabot](https://github.com/dependabot) cancel merge will cancel a previously requested merge and block automerging
  • [dependabot](https://github.com/dependabot) reopen will reopen this PR if it is closed
  • [dependabot](https://github.com/dependabot) close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • [dependabot](https://github.com/dependabot) show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • [dependabot](https://github.com/dependabot) ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • [dependabot](https://github.com/dependabot) ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • [dependabot](https://github.com/dependabot) ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.


diff --git a/requirements_dev.txt b/requirements_dev.txt
index b6bdd66..8eeaea9 100644
--- a/requirements_dev.txt
+++ b/requirements_dev.txt
@@ -1,6 +1,6 @@
 wheel
 black~=22.3.0
-flake8~=4.0.1
+flake8~=6.1.0
 mypy
 types-requests
 types-PyYAML
@ohl-bot
Copy link
Collaborator Author

ohl-bot commented Apr 6, 2025

Originally posted by Patarimi at 2023-08-30T15:18:54Z


I think that this fails because the python version used (3.6) is not supported by flake8 (docs). Since python 3.6 et 3.7 reach "end of life" (versions status), rising the minimal requirement to python 3.8 could be a good fix. What do you think ?

@ohl-bot
Copy link
Collaborator Author

ohl-bot commented Apr 6, 2025

Originally posted by donn at 2023-08-30T15:52:01Z


Patarimi I would honestly love to but that would also require us to change that requirement for OpenLane as well, which is a whole other beast. We're already requiring 3.8 for OpenLane 2.

@ohl-bot ohl-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant