Skip to content

feat: update dashboard links and remove dashboard menu item #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

feat: update dashboard links and remove dashboard menu item #620

merged 2 commits into from
Apr 29, 2025

Conversation

Gagan-Ram
Copy link
Member

@Gagan-Ram Gagan-Ram commented Apr 26, 2025 •
edited by sourcery-ai bot
Loading

Fixes: #613

Changes Made:

  • Renamed main dashboard links: "Main dashboard" on eventyay-common, "Tickets dashboard" on eventyay-tickets
  • Removed dashboard menu items from both common and tickets dashboards
  • Linked event name in top left to event dashboard on both common and tickets event pages.

Result

dashboards.mp4

Summary by Sourcery

Remove dashboard links from side navigation and repurpose the top-left header link to navigate to the relevant dashboard.

Enhancements:

  • Remove "Dashboard" and "Tickets dashboard" items from side navigation menus.
  • Make the top-left header element a direct link to the appropriate dashboard (main, tickets, or event-specific).
  • Update the text and icon of the top-left header link to indicate it leads to a dashboard.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Apr 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request removes the dedicated "Dashboard" menu items from the main navigation and updates the top-left context area to function as a clickable link to the relevant dashboard page (global or event-specific). The icon and text in the top-left area are also updated to reflect this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed dashboard menu items from navigation.
  • Removed dashboard entry from eventyay_common global navigation.
  • Removed dashboard entry from eventyay_common event navigation.
  • Removed dashboard entry from control event navigation.
  • Removed dashboard entry from control global navigation.
 src/pretix/eventyay_common/navigation.py
src/pretix/control/navigation.py
Modified the top-left context area to link to the relevant dashboard and updated its appearance.
  • Made the event name in the event context link to the event dashboard.
  • Made the user/dashboard name in the global context link to the global dashboard.
  • Updated the icon in the top-left context to a dashboard icon.
  • Updated the text in the global context to indicate 'Main dashboard' or 'Tickets dashboard'.
 src/pretix/eventyay_common/templates/eventyay_common/base.html
src/pretix/control/templates/pretixcontrol/base.html

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 26, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gagan-Ram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the commented-out code blocks in the navigation files instead of leaving them in the codebase.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Gagan-Ram
Copy link
Member Author

@mariobehling Since the "Dashboard" menu area is slightly larger compared to the other menu items, I suggest increasing the size of the dashboard icon as well (similar to what is shown in the 3rd and 6th images horizontally).
Currently, we are using the icons shown in the 2nd and 5th images.

Please share your thoughts on this suggestion.
#613

@Gagan-Ram Gagan-Ram force-pushed the feature/613-dashboard-menu-modification branch from 374d264 to 93f8eaa Compare April 29, 2025 04:01
@Gagan-Ram
feat: update dashboard links and remove dashboard menu item
b98b7d3 
- Renamed main dashboard links: "Main dashboard" on eventyay-common, "Tickets dashboard" on eventyay-tickets
- Removed dashboard menu items from both common and tickets dashboards
- Linked event name in top left to event dashboard on both common and tickets event pages.
@Gagan-Ram Gagan-Ram force-pushed the feature/613-dashboard-menu-modification branch from 93f8eaa to b98b7d3 Compare April 29, 2025 04:08
@mariobehling
Copy link
Member

@mariobehling Since the "Dashboard" menu area is slightly larger compared to the other menu items, I suggest increasing the size of the dashboard icon as well (similar to what is shown in the 3rd and 6th images horizontally). Currently, we are using the icons shown in the 2nd and 5th images.

Yes, sounds good. Go ahead.

@mariobehling mariobehling requested a review from norbusan April 29, 2025 08:41
@mariobehling mariobehling merged commit c81dbb5 into fossasia:development Apr 29, 2025
1 of 5 checks passed
@Gagan-Ram
Copy link
Member Author

Yes, sounds good. Go ahead.

No need for changes then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@hongquan hongquan hongquan approved these changes

@mariobehling mariobehling mariobehling approved these changes

@norbusan norbusan Awaiting requested review from norbusan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dashboard menu item and ensure event name links to dashboard
3 participants
@Gagan-Ram @mariobehling @hongquan