Stripe keys do not get stored

[mariobehling]

1. If the Stripe keys are updated they do not get stored in the system. A user who tries to buy a ticket will receive an error message.

Expired API Key provided: pk_live_*********************************************************************************************FhGvDD. Platform access may have been revoked.

The new keys would be entered in e.g.
https://app-test.eventyay.com/tickets/control/admin/global/settings/

After entereing the new keys here, the system still shows the same error message.

2. The second part of this issue is that the user needs to update all keys in the admin area at https://app-test.eventyay.com/tickets/control/admin/global/settings/. As some previously entered keys show ***** when entering some keys and hitting "Save" there will be an error message that the keys are wrong. Expected: Just remove the **** hiding option and always show the previously entered keys here as well.

[mariobehling]

This is probably related to PR #521

[hongquan]

@mariobehling My account (ng.hong.quan) doesn't have access to "/tickets/control/admin/global/settings/" page.

[hongquan]

Found that the form load data from pretixbase_globalsettingsobject_settingsstore table.
Looks like the PR #521 did as expected, the Stripe key is saved to a neutral place, no matter if eventyay-tickets-stripe module is installed.

But the checkout page may not use data from this place.

[hongquan]

The /checkout/payment/ page calls this code:

eventyay-tickets/src/pretix/presale/checkoutflowstep/payment_step.py

Line 33 in 2bfb277

payment_providers = self.request.event.get_payment_providers().values()

and here is how the get_payment_providers method is defined:

eventyay-tickets/src/pretix/base/models/event.py

Lines 946 to 960 in 2bfb277

	def get_payment_providers(self, cached=False) -> dict:
	"""
	Returns a dictionary of initialized payment providers mapped by their identifiers.
	"""
	from ..signals import register_payment_providers
	if not cached or not hasattr(self, "_cached_payment_providers"):
	responses = register_payment_providers.send(self)
	providers = {}
	for receiver, response in responses:
	if not isinstance(response, list):
	response = [response]
	for p in response:
	pp = p(self)
	providers[pp.identifier] = pp

The register_payment_providers.send(self) line shows that, eventyay-tickets is calling to plugins to get the list of payment providers.

[hongquan]

Ok, found the inconsistency of how to retrieve Stripe keys across components:
The "Global Settings" page retrieve the key from payment_stripe_connect_publishable_key (stored in pretixbase_globalsettingsobject_settingsstore table), while the Checkout page retrieves key from payment_stripe_publishable_key (stored in pretixbase_event_settingsstore table).

[hongquan]

When we access event.settings.some_key, the data is merged from pretixbase_globalsettingsobject_settingsstore and pretixbase_event_settingsstore, so we just need to make sure using the same key.

Prefer the payment_stripe_publishable_key because it is shorter and less confusing (don't know what connect means).

[hongquan]

For the asterisk (*) issue, I think we should add a "Reveal" button, when clicking that button, the real value of the keys will be shown.