Skip to content

Merge updates since 24 Dec 2024 from uptream #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongquan opened this issue Apr 11, 2025 · 5 comments
Open

Merge updates since 24 Dec 2024 from uptream #326

hongquan opened this issue Apr 11, 2025 · 5 comments

Comments

@hongquan
Copy link
Member

No description provided.

@hongquan
Copy link
Member Author

hongquan commented Apr 11, 2025

One challenge is the divergence of DB migration scripts:

eventyay-talk-db-migrations.txt

pretalx-db-migrations.txt

Image

Image

@hongquan hongquan changed the title Merge updates since Jan 2025 from uptream pretalx Merge updates since 24 Dec 2024 from uptream pretalx Apr 11, 2025
@mariobehling mariobehling changed the title Merge updates since 24 Dec 2024 from uptream pretalx Merge updates since 24 Dec 2024 from uptream Apr 14, 2025
@hongquan
Copy link
Member Author

hongquan commented Apr 14, 2025

Checking the applying order of those DB migration scripts:

  1. "person" module
    Image

The person/migrations/0033_merge_20241022_1752.py file was added in #225. After that, the upstream has not added any file. So this module can safely go.

  1. "submission" module

Image

The submission/migrations/0078_submissioncomment.py file was added in #255.
After that, the 0078_submissioncomment was added on upstream.

So, the first step is for the commits before the 0078_submissioncomment.py file was added (7931000).

@hongquan
Copy link
Member Author

hongquan commented Apr 15, 2025

First attempt to merge (all commits until e4449e6) (128 conflicted files):

  • Conflict of the submission/migrations/0076_submissionfavourite.py because the file is different between two repos (causing different changes of DB schema). It was added to our repo earlier than upstream.

(Left is upstream, right is our repo)
Image

-- Update --
The difference of SubmissionFavourite model was resolved in 0077_rename_submissionfavourite_submissionfavouritedeprecated.py and 0078_submissionfavourite.py by renaming our model to SubmissionFavouriteDeprecated then copying upstream SubmissionFavourite model.
So to resolve the conflict of 0076, we just accept our version.

@hongquan
Copy link
Member Author

A commit, 3723a89, was skipped in the last merge (Dec 2024). I think this commit should be taken because it enhances security.
But this commit will require us to re-implement the dropdown menu, to trigger a POST Ajax call for "logout" entry.

@hongquan
Copy link
Member Author

hongquan commented Apr 16, 2025

One of our commit, bfee7ec, deleted this checking in test cases:

assert "fa-video" not in content

Don't know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant