Skip to content

fix: Displays correct speed for the saved badges. #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: flutter_app
Choose a base branch
from
Open

fix: Displays correct speed for the saved badges. #1270

wants to merge 2 commits into from

Conversation

Vishveshwara
Copy link

@Vishveshwara Vishveshwara commented Apr 3, 2025 •
edited by sourcery-ai bot
Loading

Fixes #1269

Changes

  • Utlized getIntValue Function defined in speed.dart to get the integer value , and added 1 to it to display the exact speed value.

Screenshots / Recordings

speed.fix.mp4

Checklist:

  • No hard coding: I have used resources from constants.dart without hard coding any value.
  • No end of file edits: No modifications done at end of resource files.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • Code analyzation: My code passes analyzations run in flutter analyze and tests run in flutter test.

Summary by Sourcery

Bug Fixes:

  • Corrected the speed value display by using the getIntValue function and adding 1 to show the exact speed value

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Apr 3, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

The pull request fixes an issue where the displayed speed for saved badges was incorrect. It achieves this by utilizing the getIntValue function from speed.dart to retrieve the integer representation of the speed and then incrementing it by 1 before displaying it.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Corrected the speed value displayed for saved badges by using the getIntValue function and adding 1 to the result.
  • Imported the speed.dart file to access the getIntValue function.
  • Used the getIntValue function to get the integer value of the speed.
  • Added 1 to the integer value to display the correct speed.
  • Converted the resulting integer to a string for display.
 lib/view/widgets/save_badge_card.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#1269 The speed of animations displayed in the saved badge screen should match the actual speed value. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vishveshwara - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The code change looks good, but I'm not sure about adding 1 to the speed value directly in the UI; consider doing this in the data layer instead.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Vishveshwara
Copy link
Author

@adityastic @Jhalakupadhyay
can you please review and approve the build.

github-actions bot added a commit that referenced this pull request Apr 9, 2025
@github-actions
[Auto] Update screenshots for #1270 (2025-04-09.11:31:52)
b71ab33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Build Status

Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/14352467060/artifacts/2910602530.

Screenshots (Android)

Screenshots (iPhone)

Screenshots (iPad)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Speed of Animations stored in the saved Badge screen appears as one lower than the actual speed
1 participant
@Vishveshwara