-
Notifications
You must be signed in to change notification settings - Fork 231
Implement back and forth animation #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
According to BadgeBLE, the device only supports 8 types of animations that are already included in BadgeMagic Android app. The python version implements this back-and-forth animation by sending 2 messages to the device: One message sliding to the left then the same but sliding to the right (and repeat). However, the android version doesn't support sending more than 1 message (Please check
Therefore, we need first to modify the project to support accepting a list of messages, not only 1 message. After that, we can implement this back-and-forth animation easily. |
@mariobehling @Jhalakupadhyay I would like to work on this issue. |
@Vishveshwara go ahead and tell me if you need any help. |
@Vishveshwara @Jhalakupadhyay This needs to be thought through. We will be occupying 2 slots to make this possible so it cannot be part of the animation tab. Else you'll end up poisoning how 8 badge transfer works. |
badgemagic.app.vid.mp4@adityastic @Jhalakupadhyay |
@adityastic it should not be in animation tab I was planning to have the user to controll this by using the slots directly so that we do not need to have a particular UI for it rather it will be what user wants and this will give more freedom to user and I guess this was the reason we had 8 slots, and if are going for the slots animation we should probably have another tab for them. |
@Jhalakupadhyay we can have custom animations which can work on top of 8 badge slots. It should indeed not be in animations tab, maybe another tab? Idk but the idea is to have these animations to have no relation with the animation tab. In future we can also host the repository for prebuilt badge animations as well, I remember opening an issue for the same a while back. |
@adityastic I guess having a new tab for custom animation is the best approach here because it aligns with our current app design and makes it easier for the user to know that there is some new feature. |
@adityastic @Jhalakupadhyay Here’s my understanding of the proposed approach:
Questions I have for this issue: 1)Should the new tab be named something like "Custom Animations" or "Slot Animations"? 2)How should the UI for this tab be structured? For example:
3)Are there any specific features or constraints we should consider for the initial implementation? |
Initial start with the base I guess having a robust base for a new feature is good. |
@Jhalakupadhyay @adityastic
My Opinion: Additionally, I suggest making custom animations completely separate from the predefined modes. This ensures users have full control over their creations without relying on or being constrained by the default animations. This aligns perfectly with our goal of empowering users with greater flexibility and creative freedom. Please help me with your suggestions. |
@Vishveshwara Having tabs inside a tab view is ok but I guess not necessary but obviously we can do the other one also it depends what users like. So I will like you to build the one I suggested and if user says that they do not like it we can change it later. |
Could you please confirm if this is the direction you’d like to proceed with? If approved, I’ll start implementing this design. |
WhatsApp.Video.2025-03-15.at.23.34.12_f2180b29.mp4
please review and provide your comments. |
The Python version has a back and forth animation.
Please implement the same here
This option should be part of the animation screen (middle option).

The text was updated successfully, but these errors were encountered: