fix(payments): connector config compatibility (#1754)

Author: laouji

components/payments/cmd/connectors/internal/api/connector.go

@@ -13,11 +13,14 @@ import (
 	"github.com/formancehq/payments/internal/otel"
 	"github.com/formancehq/stack/libs/go-libs/api"
 	"github.com/formancehq/stack/libs/go-libs/bun/bunpaginate"
+	"github.com/formancehq/stack/libs/go-libs/logging"
 	"github.com/formancehq/stack/libs/go-libs/pointer"
 	"github.com/google/uuid"
 	"github.com/gorilla/mux"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/trace"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 type APIVersion int
@@ -110,14 +113,65 @@ func readConfig[Config models.ConnectorConfigObject](
 			return
 		}
 
-		err = json.NewEncoder(w).Encode(api.BaseResponse[Config]{
-			Data: &config,
-		})
+		b, err := config.Marshal()
 		if err != nil {
 			otel.RecordError(span, err)
-			api.InternalServerError(w, r, err)
+			handleConnectorsManagerErrors(w, r, err)
+			return
+		}
+
+		var m map[string]interface{}
+		err = json.Unmarshal(b, &m)
+		if err != nil {
+			otel.RecordError(span, err)
+			handleConnectorsManagerErrors(w, r, err)
+			return
+		}
+
+		// inject provider into config json so SDK can distinguish between config types
+		caser := cases.Title(language.English)
+		m["provider"] = caser.String(connectorID.Provider.String())
+
+		// rewrite pollingDuration struct as a string to match API spec
+		pollingPeriod, ok := m["pollingPeriod"].(map[string]interface{})
+		if ok {
+			duration, found := pollingPeriod["duration"]
+			if found {
+				var ns int64
+				switch v := duration.(type) {
+				case int64:
+					ns = v
+				case float64:
+					ns = int64(v)
+				default:
+					logging.FromContext(ctx).Debugf("pollingPeriod.Duration was of an unexpected type: %T", v)
+				}
+				m["pollingPeriod"] = time.Duration(ns).String()
+			}
+		}
+
+		result, err := json.Marshal(m)
+		if err != nil {
+			otel.RecordError(span, err)
+			handleConnectorsManagerErrors(w, r, err)
 			return
 		}
+
+		rawConfig := json.RawMessage(result)
+		writeConfig(w, r, rawConfig, span)
+	}
+}
+
+func writeConfig(w http.ResponseWriter, r *http.Request, v any, span trace.Span) {
+	resBody := api.BaseResponse[any]{
+		Data: &v,
+	}
+	w.Header().Set("Content-Type", "application/json")
+	if v != nil {
+		if err := json.NewEncoder(w).Encode(resBody); err != nil {
+			otel.RecordError(span, err)
+			api.InternalServerError(w, r, err)
+		}
 	}
 }
 

components/payments/go.mod

@@ -43,6 +43,7 @@ require (
 	go.uber.org/mock v0.3.0
 	golang.org/x/oauth2 v0.16.0
 	golang.org/x/sync v0.5.0
+	golang.org/x/text v0.14.0
 )
 
 require (
@@ -194,7 +195,6 @@ require (
 	golang.org/x/mod v0.11.0 // indirect
 	golang.org/x/net v0.21.0 // indirect
 	golang.org/x/sys v0.18.0 // indirect
-	golang.org/x/text v0.14.0 // indirect
 	golang.org/x/tools v0.7.0 // indirect
 	google.golang.org/appengine v1.6.8 // indirect
 	google.golang.org/genproto/googleapis/api v0.0.0-20240125205218-1f4bbc51befe // indirect