Skip to content

Commit 0a0d256

Browse files
committed
feat(models): handle trailing separators for package directories
Signed-off-by: Lexus Drumgold <[email protected]>
1 parent 24c19d9 commit 0a0d256

6 files changed

+16
-16
lines changed

src/models/__tests__/err-invalid-package-target.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('unit:models/ERR_INVALID_PACKAGE_TARGET', () => {
1414

1515
beforeEach(() => {
1616
base = import.meta.url
17-
dir = process.cwd() + '/'
17+
dir = process.cwd()
1818
key = '.'
1919
target = 'dist/index.mjs'
2020
})
@@ -43,23 +43,23 @@ describe('unit:models/ERR_INVALID_PACKAGE_TARGET', () => {
4343
target,
4444
undefined,
4545
undefined,
46-
`Invalid "exports" main target "${target}" defined in the package config ${dir}package.json; targets must start with "./"`
46+
`Invalid "exports" main target "${target}" defined in the package config ${dir}/package.json; targets must start with "./"`
4747
],
4848
[
49-
dir,
49+
dir + '/',
5050
key + '/utils',
5151
'dist/utils.mjs',
5252
undefined,
5353
undefined,
54-
`Invalid "exports" target "dist/utils.mjs" defined for './utils' in the package config ${dir}package.json; targets must start with "./"`
54+
`Invalid "exports" target "dist/utils.mjs" defined for './utils' in the package config ${dir}/package.json; targets must start with "./"`
5555
],
5656
[
57-
'',
57+
dir,
5858
'#src',
5959
'src/index.ts',
6060
true,
6161
base,
62-
`Invalid "imports" target "src/index.ts" defined for '#src' in the package config package.json imported from ${base}`
62+
`Invalid "imports" target "src/index.ts" defined for '#src' in the package config ${dir}/package.json imported from ${base}`
6363
]
6464
]
6565

src/models/__tests__/err-package-import-not-defined.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('unit:models/ERR_PACKAGE_IMPORT_NOT_DEFINED', () => {
4242
specifier,
4343
base,
4444
dir,
45-
`${message} in package ${dir}package.json imported from ${base}`
45+
`${message} in package ${dir}/package.json imported from ${base}`
4646
]
4747
]
4848

src/models/__tests__/err-package-path-not-exported.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe('unit:models/ERR_PACKAGE_PATH_NOT_EXPORTED', () => {
1313

1414
beforeEach(() => {
1515
base = import.meta.url
16-
dir = process.cwd() + 'node_modules/@flex-development/errnode/'
16+
dir = process.cwd() + '/' + 'node_modules/@flex-development/errnode'
1717
subpath = '.'
1818
})
1919

@@ -39,25 +39,25 @@ describe('unit:models/ERR_PACKAGE_PATH_NOT_EXPORTED', () => {
3939
dir,
4040
subpath,
4141
undefined,
42-
`No 'exports' main defined in ${dir}package.json`
42+
`No 'exports' main defined in ${dir}/package.json`
4343
],
4444
[
45-
dir,
45+
dir + '/',
4646
subpath,
4747
base,
48-
`No 'exports' main defined in ${dir}package.json imported from ${base}`
48+
`No 'exports' main defined in ${dir}/package.json imported from ${base}`
4949
],
5050
[
5151
dir,
5252
subpath + '/internal/format-message',
5353
undefined,
54-
`Package subpath '${subpath}/internal/format-message' is not defined by 'exports' in ${dir}package.json`
54+
`Package subpath '${subpath}/internal/format-message' is not defined by 'exports' in ${dir}/package.json`
5555
],
5656
[
5757
dir,
5858
subpath + '/utils/create-node-error',
5959
base,
60-
`Package subpath '${subpath}/utils/create-node-error' is not defined by 'exports' in ${dir}package.json imported from ${base}`
60+
`Package subpath '${subpath}/utils/create-node-error' is not defined by 'exports' in ${dir}/package.json imported from ${base}`
6161
]
6262
]
6363

src/models/err-invalid-package-target.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const ERR_INVALID_PACKAGE_TARGET: NodeErrorConstructor<
8282
if (!main) ret += ` for '${key}'`
8383

8484
// add package.json location
85-
ret += ` in the package config ${dir}package.json`
85+
ret += ` in the package config ${dir.replace(/\/$/, '')}/package.json`
8686

8787
// add import location
8888
if (base) ret += ` imported from ${base}`

src/models/err-package-import-not-defined.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const ERR_PACKAGE_IMPORT_NOT_DEFINED: NodeErrorConstructor<
5050
let message: string = `Package import specifier '${specifier}' is not defined`
5151

5252
// add package.json location
53-
if (dir) message += ` in package ${dir}package.json`
53+
if (dir) message += ` in package ${dir.replace(/\/$/, '')}/package.json`
5454

5555
// add import location
5656
message += ` imported from ${base}`

src/models/err-package-path-not-exported.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const ERR_PACKAGE_PATH_NOT_EXPORTED: NodeErrorConstructor<
5353
: `Package subpath '${subpath}' is not defined by 'exports' in`
5454

5555
// add package.json location
56-
message += ` ${dir}package.json`
56+
message += ` ${dir.replace(/\/$/, '')}/package.json`
5757

5858
// add import location
5959
if (base) message += ` imported from ${base}`

0 commit comments

Comments
 (0)