Fix div zero panic from zero fb calculation (#35) #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieniven
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR resolves the issue found on stress test where if the FCU arrives at just nice target_time-leeway_time, time drift calculated will be zero. This results in during calculate_flashblocks operation, the number of flashblocks to be built to be equal to zero, causing a panic on subsequent gas limit calculation due to a div-zero error.
The PR fixes handling on calculating time drift to additionally check if time drift is > 0.
Context of the issue:
✅ I have completed the following steps:
make lintmake test