Skip to content

[2.x] Make sure all common JS components, etc... are accessible #4219

@dsevillamartin

Description

@dsevillamartin

Current Behavior

The common component LabelValue seems to only be imported as UserSecurityPage (forum) -> AccessTokenList -> LabelValue, so it got code split. It should be explicitly imported in common.ts so that its accessible all the time in forum & at all in admin.

There may be other common files that this could've happened to.

Steps to Reproduce

import LabelValue from 'flarum/common/components/LabelValue';

import LabelValue from '../../common/components/LabelValue';

Expected Behavior

No error

Screenshots

Image

Environment

  • Flarum version: 2.0 dev (4e95d06)

Output of php flarum info

No response

Possible Solution

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions