Skip to content

Commit 8437242

Browse files
authored
[shell-operator] Bump deckhouse logger (#774)
Signed-off-by: Pavel Okhlopkov <[email protected]>
1 parent 1c5d51b commit 8437242

File tree

11 files changed

+26
-28
lines changed

11 files changed

+26
-28
lines changed

cmd/shell-operator/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
func main() {
1717
kpApp := kingpin.New(app.AppName, fmt.Sprintf("%s %s: %s", app.AppName, app.Version, app.AppDescription))
1818

19-
logger := log.NewLogger(log.Options{})
19+
logger := log.NewLogger()
2020
log.SetDefault(logger)
2121

2222
// override usage template to reveal additional commands with information about start command

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ module github.com/flant/shell-operator
33
go 1.23.8
44

55
require (
6-
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250424095005-9ab587d01d7a
7-
github.com/flant/kube-client v1.3.0
6+
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250704135428-7600b0581807
7+
github.com/flant/kube-client v1.3.1
88
github.com/go-chi/chi/v5 v5.2.1
99
github.com/go-openapi/spec v0.19.8
1010
github.com/go-openapi/strfmt v0.19.5

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ3
3434
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
3535
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
3636
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
37-
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250424095005-9ab587d01d7a h1:c4CKIIsfpCn9wzMziOPfrqptAuHLCtTPM/heobSxPfk=
38-
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250424095005-9ab587d01d7a/go.mod h1:pbAxTSDcPmwyl3wwKDcEB3qdxHnRxqTV+J0K+sha8bw=
37+
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250704135428-7600b0581807 h1:0kf//0CzwRhJZBTz3yzeZtHIQumWqsCU0DR+HM5r+PA=
38+
github.com/deckhouse/deckhouse/pkg/log v0.0.0-20250704135428-7600b0581807/go.mod h1:pbAxTSDcPmwyl3wwKDcEB3qdxHnRxqTV+J0K+sha8bw=
3939
github.com/deckhouse/module-sdk v0.2.2 h1:IzfWxmHiA0+F+R82qPr/JGef2kWBaXBu4tO0uo0Qzxw=
4040
github.com/deckhouse/module-sdk v0.2.2/go.mod h1:Ps92/zmKfkRMJF79/uxCba94ldvqtsV00sUCbTFj4zw=
4141
github.com/docker/go-units v0.4.0/go.mod h1:fgPhTUdO+D/Jk86RDLlptpiXQzgHJF7gydDDbaIK4Dk=
@@ -51,8 +51,8 @@ github.com/evanphx/json-patch/v5 v5.9.0 h1:kcBlZQbplgElYIlo/n1hJbls2z/1awpXxpRi0
5151
github.com/evanphx/json-patch/v5 v5.9.0/go.mod h1:VNkHZ/282BpEyt/tObQO8s5CMPmYYq14uClGH4abBuQ=
5252
github.com/flant/go-openapi-validate v0.19.12-flant.0 h1:xk6kvc9fHKMgUdB6J7kbpbLR5vJOUzKAK8p3nrD7mDk=
5353
github.com/flant/go-openapi-validate v0.19.12-flant.0/go.mod h1:Rzou8hA/CBw8donlS6WNEUQupNvUZ0waH08tGe6kAQ4=
54-
github.com/flant/kube-client v1.3.0 h1:iVxwpUZO4AhURkq6n44qfzp0Bjs5WatzTtJrfxeRDkE=
55-
github.com/flant/kube-client v1.3.0/go.mod h1:yaFoNwyomNm0/OLXRxGYvR7or2pfLv9M9qPDSPPwljI=
54+
github.com/flant/kube-client v1.3.1 h1:1SdD799sujXNg2F6Z27le/+qkcKQaKf9Z492YGEhVhc=
55+
github.com/flant/kube-client v1.3.1/go.mod h1:mql6hsZMgBLAhdj3Emb8TrP5MVdXduFQ2NLjzn6IF0Y=
5656
github.com/globalsign/mgo v0.0.0-20180905125535-1ca0a4f7cbcb/go.mod h1:xkRDCp4j0OGD1HRkm4kmhM+pmpv3AKq5SU7GMg4oO/Q=
5757
github.com/go-chi/chi/v5 v5.2.1 h1:KOIHODQj58PmL80G2Eak4WdvUzjSJSm0vG72crDCqb8=
5858
github.com/go-chi/chi/v5 v5.2.1/go.mod h1:L2yAIGWB3H+phAw1NxKwWM+7eUH/lU8pOMm5hHcoops=

pkg/executor/executor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func NewExecutor(dir string, entrypoint string, args []string, envs []string) *E
9292
ex := &Executor{
9393
cmd: cmd,
9494
proxyJsonKey: "proxyJsonLog",
95-
logger: log.NewLogger(log.Options{}).Named("auto-executor"),
95+
logger: log.NewLogger().Named("auto-executor"),
9696
}
9797

9898
return ex

pkg/executor/executor_test.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,15 @@ import (
1616
)
1717

1818
func TestRunAndLogLines(t *testing.T) {
19-
loggerOpts := log.Options{
20-
TimeFunc: func(_ time.Time) time.Time {
21-
parsedTime, err := time.Parse(time.DateTime, "2006-01-02 15:04:05")
22-
if err != nil {
23-
assert.NoError(t, err)
24-
}
25-
26-
return parsedTime
27-
},
19+
timeFunc := func(_ time.Time) time.Time {
20+
parsedTime, err := time.Parse(time.DateTime, "2006-01-02 15:04:05")
21+
if err != nil {
22+
assert.NoError(t, err)
23+
}
24+
25+
return parsedTime
2826
}
29-
logger := log.NewLogger(loggerOpts)
27+
logger := log.NewLogger(log.WithTimeFunc(timeFunc))
3028
logger.SetLevel(log.LevelInfo)
3129

3230
var buf bytes.Buffer

pkg/metric_storage/vault/vault_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
func Test_CounterAdd(t *testing.T) {
1515
g := NewWithT(t)
1616

17-
logger := log.NewLogger(log.Options{})
17+
logger := log.NewLogger()
1818
log.SetDefault(logger)
1919

2020
buf := &bytes.Buffer{}

pkg/shell-operator/operator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func NewShellOperator(ctx context.Context, opts ...Option) *ShellOperator {
8686
}
8787

8888
if so.logger == nil {
89-
so.logger = log.NewLogger(log.Options{}).Named("shell-operator")
89+
so.logger = log.NewLogger().Named("shell-operator")
9090
}
9191

9292
return so

pkg/utils/file/file_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,17 +123,17 @@ func TestRecursiveCheckLibDirectory(t *testing.T) {
123123
for _, tt := range tests {
124124
var buf bytes.Buffer
125125

126-
logger := log.NewLogger(log.Options{
127-
Output: &buf,
128-
TimeFunc: func(_ time.Time) time.Time {
126+
logger := log.NewLogger(
127+
log.WithOutput(&buf),
128+
log.WithTimeFunc(func(_ time.Time) time.Time {
129129
parsedTime, err := time.Parse(time.DateTime, "2006-01-02 15:04:05")
130130
if err != nil {
131131
assert.NoError(t, err)
132132
}
133133

134134
return parsedTime
135-
},
136-
})
135+
}),
136+
)
137137

138138
log.SetDefault(logger)
139139

pkg/utils/structured-logger/structured_logger.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type StructuredLogger struct {
2727
}
2828

2929
func (l *StructuredLogger) NewLogEntry(r *http.Request) middleware.LogEntry {
30-
entry := &StructuredLoggerEntry{Logger: log.NewLogger(log.Options{})}
30+
entry := &StructuredLoggerEntry{Logger: log.NewLogger()}
3131

3232
entry.Logger = entry.Logger.With(
3333
// TODO: make snake_case

pkg/webhook/admission/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func NewWebhookHandler() *WebhookHandler {
3737
})
3838

3939
rtr.Group(func(r chi.Router) {
40-
r.Use(structuredLogger.NewStructuredLogger(log.NewLogger(log.Options{}).Named("admissionWebhook"), "admissionWebhook"))
40+
r.Use(structuredLogger.NewStructuredLogger(log.NewLogger().Named("admissionWebhook"), "admissionWebhook"))
4141
r.Use(middleware.Recoverer)
4242
r.Use(middleware.AllowContentType("application/json"))
4343
r.Post("/*", h.serveReviewRequest)

0 commit comments

Comments
 (0)