Skip to content

Commit a2d59d7

Browse files
Add missing exports (#38)
* Add missing exports * Fix test
1 parent 2be58cc commit a2d59d7

File tree

5 files changed

+49
-19
lines changed

5 files changed

+49
-19
lines changed

examples/transcription/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
from transcription.room import RoomService, fishjam
77
from transcription.worker import async_worker
88

9-
from fishjam import PeerOptions, SubscribeOptions
9+
from fishjam import PeerOptions
10+
from fishjam.peer import SubscribeOptions
1011

1112
_room_service: RoomService | None = None
1213

fishjam/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
PeerOptions,
2323
Room,
2424
RoomOptions,
25-
SubscribeOptions,
2625
)
2726

2827
__all__ = [
@@ -31,7 +30,6 @@
3130
"receive_binary",
3231
"PeerMetadata",
3332
"PeerOptions",
34-
"SubscribeOptions",
3533
"RoomOptions",
3634
"Room",
3735
"Peer",

fishjam/peer/__init__.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1-
from fishjam._openapi_client.models import PeerStatus, PeerType
1+
from fishjam._openapi_client.models import (
2+
PeerMetadata,
3+
PeerStatus,
4+
PeerType,
5+
SubscribeOptions,
6+
SubscribeOptionsAudioFormat,
7+
SubscribeOptionsAudioSampleRate,
8+
)
29

3-
__all__ = ["PeerStatus", "PeerType"]
10+
__all__ = [
11+
"PeerMetadata",
12+
"PeerStatus",
13+
"PeerType",
14+
"SubscribeOptions",
15+
"SubscribeOptionsAudioFormat",
16+
"SubscribeOptionsAudioSampleRate",
17+
]

tests/agent/test_agent.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55
import pytest
66
import pytest_asyncio
77

8-
from fishjam import FishjamClient, FishjamNotifier
8+
from fishjam import FishjamClient, FishjamNotifier, Room
99
from fishjam.agent.agent import Agent
1010
from fishjam.agent.errors import AgentAuthError
11-
from fishjam.api._fishjam_client import Room
1211
from fishjam.events._protos.fishjam import (
1312
ServerMessagePeerDisconnected,
1413
ServerMessagePeerMetadataUpdated,

tests/test_room_api.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,30 @@
77

88
from fishjam import (
99
FishjamClient,
10+
Peer,
1011
PeerOptions,
12+
Room,
1113
RoomOptions,
1214
)
13-
from fishjam._openapi_client.models import (
15+
from fishjam.errors import (
16+
BadRequestError,
17+
NotFoundError,
18+
ServiceUnavailableError,
19+
UnauthorizedError,
20+
)
21+
from fishjam.peer import (
1422
PeerMetadata,
1523
PeerStatus,
1624
PeerType,
25+
SubscribeOptions,
26+
SubscribeOptionsAudioFormat,
27+
SubscribeOptionsAudioSampleRate,
28+
)
29+
from fishjam.room import (
1730
RoomConfig,
1831
RoomConfigRoomType,
1932
RoomConfigVideoCodec,
2033
)
21-
from fishjam.api._fishjam_client import Peer, Room
22-
from fishjam.errors import (
23-
BadRequestError,
24-
NotFoundError,
25-
ServiceUnavailableError,
26-
UnauthorizedError,
27-
)
2834

2935
HOST = "fishjam" if os.getenv("DOCKER_TEST") == "TRUE" else "localhost"
3036
FISHJAM_URL = f"http://{HOST}:5002"
@@ -179,7 +185,12 @@ def test_id_not_found(self, room_api):
179185

180186
class TestCreatePeer:
181187
def _assert_peer_created(
182-
self, room_api, webrtc_peer, room_id, server_metadata=None
188+
self,
189+
room_api,
190+
webrtc_peer,
191+
room_id,
192+
server_metadata=None,
193+
subscribe=None,
183194
):
184195
server_metadata = server_metadata or {}
185196

@@ -189,19 +200,26 @@ def _assert_peer_created(
189200
status=PeerStatus("disconnected"),
190201
tracks=[],
191202
metadata=PeerMetadata.from_dict({"peer": {}, "server": server_metadata}),
192-
subscribe=None,
203+
subscribe=subscribe,
193204
)
194205

195206
room = room_api.get_room(room_id)
196207
assert peer in room.peers
197208

198209
def test_with_specified_options(self, room_api: FishjamClient):
199-
options = PeerOptions(enable_simulcast=True)
210+
subscribe = SubscribeOptions(
211+
audio_format=SubscribeOptionsAudioFormat.PCM16,
212+
audio_sample_rate=SubscribeOptionsAudioSampleRate.VALUE_16000,
213+
)
214+
options = PeerOptions(
215+
enable_simulcast=True,
216+
subscribe=subscribe,
217+
)
200218

201219
room = room_api.create_room()
202220
peer, _token = room_api.create_peer(room.id, options=options)
203221

204-
self._assert_peer_created(room_api, peer, room.id)
222+
self._assert_peer_created(room_api, peer, room.id, subscribe=subscribe)
205223

206224
def test_with_metadata(self, room_api: FishjamClient):
207225
options = PeerOptions(metadata={"is_test": True})

0 commit comments

Comments
 (0)