Skip to content

Commit 5fc9369

Browse files
authored
feat: update docker-for-mac version check (#22)
Docker-for-mac fixed the issue in 4.43.2; update the get-core.sh script to check only for the affected versions.
1 parent 8b559e7 commit 5fc9369

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

get-core.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,14 @@ ensure_docker_is_installed() {
5858
}
5959

6060
check_docker_version() {
61-
# Explicitly inform the user about the known io_uring issue in Docker Desktop 4.42.1 on Mac
61+
# Explicitly inform the user about the known io_uring issue in Docker Desktop for Mac
62+
# See also:
63+
# * https://github.com/firebolt-db/firebolt-core/issues/9
64+
# * https://github.com/docker/for-mac/issues/7707
6265
if [ "$(uname)" = "Darwin" ]; then
6366
version=$(docker version | sed -n 's/.*Docker Desktop \([0-9.]*\).*/\1/p')
64-
if [ "$version" = "4.42.1" ]; then
65-
echo "[❌] Firebolt Core cannot run with Docker Desktop verion ${version} on Mac, as it contains a known bug: https://github.com/firebolt-db/firebolt-core/issues/9"
67+
if [ "$version" = "4.42.1" ] || [ "$version" = "4.43.0" ] || [ "$version" = "4.43.1" ]; then
68+
echo "[❌] Firebolt Core cannot run with Docker Desktop version ${version} on Mac, as it contains a known io_uring issue; please use version 4.43.2+"
6669
return 1
6770
fi
6871
fi

0 commit comments

Comments
 (0)