Skip to content

Commit 47f6924

Browse files
Provide full path to volume (#15)
* Provide full path to docker volume
1 parent e3616c7 commit 47f6924

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

get-core.sh

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,16 @@ banner() {
3232
# Docker image to pull
3333
DOCKER_IMAGE="ghcr.io/firebolt-db/firebolt-core:preview-rc"
3434
EXTERNAL_PORT=3473
35-
DOCKER_RUN_ARGS="-i --name firebolt-core --rm --ulimit memlock=8589934592:8589934592 --security-opt seccomp=unconfined -v ./firebolt-core-data:/firebolt-core/volume -p $EXTERNAL_PORT:3473 $DOCKER_IMAGE"
35+
DOCKER_RUN_ARGS=(
36+
-i
37+
--name firebolt-core
38+
--rm
39+
--ulimit memlock=8589934592:8589934592
40+
--security-opt seccomp=unconfined
41+
-v "$(pwd)/firebolt-core-data:/firebolt-core/volume"
42+
-p "$EXTERNAL_PORT:3473"
43+
"$DOCKER_IMAGE"
44+
)
3645

3746
ensure_docker_is_installed() {
3847
if docker info >/dev/null 2>&1; then
@@ -113,7 +122,7 @@ run_docker_image() {
113122
case "$answer" in
114123
[yY])
115124
echo -n "[🔥] Starting the Firebolt Core Docker container"
116-
CID="$(docker run --detach $DOCKER_RUN_ARGS)"
125+
CID="$(docker run --detach "${DOCKER_RUN_ARGS[@]}")"
117126
trap "docker kill $CID" EXIT
118127
echo ""
119128

@@ -125,7 +134,7 @@ run_docker_image() {
125134
*)
126135
echo "[🔥] Firebolt Core is ready to be executed, you can do this by running the following command:"
127136
echo
128-
echo "docker run --name firebolt-core $DOCKER_RUN_ARGS"
137+
echo "docker run "${DOCKER_RUN_ARGS[@]}""
129138
echo
130139
echo "And then in another terminal:"
131140
echo

0 commit comments

Comments
 (0)