Make compatible with dovecot v2.4+ #35
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable adaptations: - Removed `FTS_LOOKUP_FLAG_NO_AUTO_FUZZY` and related code entirely. Dropped from dovecot in: dovecot/core@8745b77 - Remove usage of fts_mail_user_deinit(). Dropped from dovecot in: dovecot/core@0cfb947 - Migrate settings to new layout, and remove bespoke settings initalization function `fts_elastic_plugin_init_settings()`. - Adapt to new event-based plugin interface. Not very familiar with either dovecot or C, so not 100% sure of what I'm doing, but this at least builds and serves as a starting point. I did not consider compatibility with dovecot older than 2.4, so a few ifdefs might need to be added to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
We're in the process of upgrading the dovcot package for Arch Linux from version 2.3.21.1 to 2.4.1, so I've spent some time on trying to make this plugin compatible.
Notable adaptations:
Removed
FTS_LOOKUP_FLAG_NO_AUTO_FUZZYand related code entirely. Dropped fromdovecot in:
dovecot/core@8745b77
Remove usage of fts_mail_user_deinit(). Dropped from dovecot in:
dovecot/core@0cfb947
Migrate settings to new layout, and remove bespoke settings initalization
function
fts_elastic_plugin_init_settings().Adapt to new event-based plugin interface.
Not very familiar with either dovecot or C, so not 100% sure of what I'm doing, but this at least builds and serves as a starting point. I did not consider compatibility with dovecot older than 2.4, so a few ifdefs might need to be added to fix that.
Cheers!
CC: @hashworks @foxxx0 @grawlinson