Skip to content

Add support for flake8 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adius opened this issue Feb 22, 2018 · 2 comments
Open

Add support for flake8 #35

adius opened this issue Feb 22, 2018 · 2 comments

Comments

@adius
Copy link
Contributor

adius commented Feb 22, 2018

https://pypi.python.org/pypi/flake8

As seen in thread/routemaster#41 (comment)

Configuration is stored in setup.cfg

@danpalmer
Copy link

Configuration can be stored in many different files. setup.cfg is probably the most common for flake8, but there are other valid places, and some flake8 plugins may also use config from other places. For example, flake8-isort calls into isort which many people configure through an isort.cfg plugin (even though it can be configured through setup.cfg).

Worth noting that most uses of flake8 I've seen use a custom set of plugins, often pinned to versions, so any automated system would need the ability to pickup that list of dependencies and install them. This has been the main blocker to hosted Python linting solutions in the past, and one of the reasons we just fail our build when there are linter violations.

@adius
Copy link
Contributor Author

adius commented Feb 22, 2018

Wow, sounds complicated 😅. Thanks for the heads up. Maybe we can support a subset of the features for the beginning and ignore the rest.
(The big advantage of Feram is no setup time, and much faster than CI. So if Feram already fails before your CI you can can just cancel the build and fix the bug before retrying. Saves a lot of time. So even just a subset is helpful for the beginning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants