breaking: change the signature of after request functions #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AfterRequestFunc type signature is now `fn(&Request, &mut Response)`. This change allows information from the request to be used in typical post-request tasks such as logging in a standard format or reporting request timings.
Nuked ssl features, since those are no longer part of hyper and we're not using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AfterRequestFunc type signature is now
fn(&Request, &mut Response). This change allows information from the request to be used in typical post-request tasks such as logging in a standard format or reporting request timings. Specifically I needed to log in the Apache common log format, which includes request info, the response status code, and the size of the response body in bytes.