Merge pull request #60 from fastbill/#59/master/add-iban-validation

#59/master/add iban validation

Author: teiling88

composer.json

@@ -5,7 +5,8 @@
     "require": {
         "guzzlehttp/guzzle": "^7.0",
         "php": "^8.0",
-        "ext-simplexml": "*"
+        "ext-simplexml": "*",
+        "jschaedl/iban-validation": "^2.5"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5.25"

src/Customer/CustomerValidator.php

@@ -4,6 +4,8 @@
 namespace FastBillSdk\Customer;
 
 use FastBillSdk\Common\MissingPropertyException;
+use Iban\Validation\Iban;
+use Iban\Validation\Validator;
 
 class CustomerValidator
 {
@@ -35,6 +37,12 @@ public function validateRequiredCreationProperties(CustomerEntity $entity): arra
             $errorMessages[] = $exception->getMessage();
         }
 
+        try {
+            $this->checkIban($entity);
+        } catch (MissingPropertyException $exception) {
+            $errorMessages[] = $exception->getMessage();
+        }
+
         return $errorMessages;
     }
 
@@ -108,4 +116,15 @@ private function isBusiness(CustomerEntity $entity): bool
     {
         return $entity->customerType === CustomerEntity::CUSTOMER_TYPE_BUSINESS;
     }
+
+    private function checkIban(CustomerEntity $entity)
+    {
+        if ($entity->bankIban) {
+            $iban = new Iban($entity->bankIban);
+            $validator = new Validator();
+            if (!$validator->validate($iban)) {
+                throw new MissingPropertyException('The property bankIban is not valid!');
+            }
+        }
+    }
 }

tests/Customer/CustomerValidationTest.php

@@ -0,0 +1,25 @@
+<?php
+declare(strict_types=1);
+
+namespace FastBillSdkTest\Customer;
+
+use FastBillSdk\Customer\CustomerEntity;
+use FastBillSdk\Customer\CustomerValidator;
+use FastBillSdkTest\Common\BaseTestTrait;
+use PHPUnit\Framework\TestCase;
+
+class CustomerValidationTest extends TestCase
+{
+    use BaseTestTrait;
+
+    public function testIbanValidation()
+    {
+        $customer = new CustomerEntity();
+        $customer->bankIban = 'DE99370400440532013000'; // Example wrong IBAN
+
+        $validator = new CustomerValidator();
+        $errors = $validator->validateRequiredCreationProperties($customer);
+
+        self::assertContains('The property bankIban is not valid!', $errors);
+    }
+}