Appease mypy

Author: savannahostrowski

pyproject.toml

@@ -121,10 +121,3 @@ known-third-party = ["typer", "fastapi"]
 [tool.ruff.lint.pyupgrade]
 # Preserve types, even if a file imports `from __future__ import annotations`.
 keep-runtime-typing = true
-
-[dependency-groups]
-dev = [
-    "coverage>=7.6.1",
-    "pytest>=8.3.5",
-    "respx>=0.22.0",
-]

src/fastapi_cloud_cli/commands/new.py

@@ -23,7 +23,7 @@ def main():
 class ProjectConfig:
     name: str
     path: pathlib.Path
-    extra_args: list = field(default_factory=list)
+    extra_args: list[str] = field(default_factory=list)
 
 def _generate_readme(project_name: str) -> str:
     return f"""# {project_name}
@@ -62,7 +62,7 @@ def _exit_with_error(toolkit: RichToolkit, error_msg: str) -> None:
     toolkit.print(f"[bold red]Error:[/bold red] {error_msg}", tag="error")
     raise typer.Exit(code=1)
 
-def _validate_python_version_in_args(extra_args: list) -> Optional[str]:
+def _validate_python_version_in_args(extra_args: list[str]) -> Optional[str]:
     """
     Check if --python is specified in extra_args and validate it's >= 3.8.
     Returns error message if < 3.8, None otherwise.
@@ -86,6 +86,7 @@ def _validate_python_version_in_args(extra_args: list) -> Optional[str]:
             except (ValueError, IndexError):
                 # Malformed version - let uv handle the error
                 return None
+    return None
 
 def _setup(toolkit: RichToolkit, config: ProjectConfig) -> None:
     error = _validate_python_version_in_args(config.extra_args)

tests/test_cli_new.py

@@ -1,4 +1,6 @@
 import shutil
+from pathlib import Path
+from typing import Any
 
 import pytest
 from typer.testing import CliRunner
@@ -9,22 +11,22 @@
 
 
 @pytest.fixture
-def temp_project_dir(tmp_path, monkeypatch):
+def temp_project_dir(tmp_path: Path, monkeypatch: Any) -> Path:
     """Create a temporary directory and cd into it."""
     monkeypatch.chdir(tmp_path)
     return tmp_path
 
 
 @pytest.fixture(autouse=True)
-def check_uv_installed():
+def check_uv_installed() -> None:
     """Skip tests if uv is not installed."""
     if not shutil.which("uv"):
         pytest.skip("uv is not installed")
 
 
 class TestNewCommand:
 
-    def test_creates_project_successfully(self, temp_project_dir):
+    def test_creates_project_successfully(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "my_fastapi_project"])
 
         assert result.exit_code == 0
@@ -35,7 +37,7 @@ def test_creates_project_successfully(self, temp_project_dir):
         assert "Success!" in result.output
         assert "my_fastapi_project" in result.output
 
-    def test_creates_project_with_python_flag(self, temp_project_dir):
+    def test_creates_project_with_python_flag(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "my_fastapi_project", "--python", "3.12"])
 
         assert result.exit_code == 0
@@ -47,7 +49,7 @@ def test_creates_project_with_python_flag(self, temp_project_dir):
         assert "3.12" in python_version_file
         assert "Success!" in result.output
 
-    def test_creates_project_with_python_flag_short(self, temp_project_dir):
+    def test_creates_project_with_python_flag_short(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "another_project", "-p", "3.9"])
         assert result.exit_code == 0
         project_path = temp_project_dir / "another_project"
@@ -56,7 +58,7 @@ def test_creates_project_with_python_flag_short(self, temp_project_dir):
         assert "3.9" in python_version_file
 
 
-    def test_creates_project_with_multiple_flags(self, temp_project_dir):
+    def test_creates_project_with_multiple_flags(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "my_fastapi_project", "--python", "3.12", "--lib"])
 
         assert result.exit_code == 0
@@ -67,14 +69,14 @@ def test_creates_project_with_multiple_flags(self, temp_project_dir):
         assert (project_path / "main.py").exists()
         assert (project_path / "README.md").exists()
 
-    def test_rejects_python_below_3_8(self, temp_project_dir):
+    def test_rejects_python_below_3_8(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "my_fastapi_project", "--python", "3.7"])
 
         assert result.exit_code == 1
         assert "Python 3.7 is not supported" in result.output
         assert "FastAPI requires Python 3.8" in result.output
 
-    def test_rejects_existing_directory(self, temp_project_dir):
+    def test_rejects_existing_directory(self, temp_project_dir: Path) -> None:
         existing_dir = temp_project_dir / "existing_project"
         existing_dir.mkdir()
 
@@ -83,7 +85,7 @@ def test_rejects_existing_directory(self, temp_project_dir):
         assert result.exit_code == 1
         assert f"Directory 'existing_project' already exists." in result.output
 
-    def test_initializes_in_current_directory_when_no_name_provided(self, temp_project_dir):
+    def test_initializes_in_current_directory_when_no_name_provided(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new"])
 
         assert result.exit_code == 0
@@ -97,7 +99,7 @@ def test_initializes_in_current_directory_when_no_name_provided(self, temp_proje
         assert (temp_project_dir / "README.md").exists()
         assert (temp_project_dir / "pyproject.toml").exists()
 
-    def test_validate_file_contents(self, temp_project_dir):
+    def test_validate_file_contents(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "sample_project"])
 
         assert result.exit_code == 0
@@ -111,7 +113,7 @@ def test_validate_file_contents(self, temp_project_dir):
         assert "# sample_project" in readme_content
         assert "A project created with FastAPI Cloud CLI." in readme_content
 
-    def test_validate_pyproject_toml_contents(self, temp_project_dir):
+    def test_validate_pyproject_toml_contents(self, temp_project_dir: Path) -> None:
         result = runner.invoke(app, ["new", "test_project"])
 
         assert result.exit_code == 0