Unable to import third of three images.

[marc-git]

Hello,

Today I was simply unable to insert the third picture of the three I had uploaded into the FAILS system. I am sure this will be quite repeatable.
I was unable to select the image although all three images were displayed as available. Clicking the third sometimes led to selecting the second image, sometimes the first.

VG,

Marc

[marc-git]

I was in Room H0104 at TU Berlin Charlottenburg.

[martenrichter]

Interesting, I will try to reproduce this. Indeed there were changes in this part of the code. It is in preparation for the form feature (rectangle, circle, lines...), which is already distributed in the stable version, but not activated.

So it is likely to be caused by changes in this part. (It shares some logic with the picture code).
Did it only appear this week? Or also last week? (Different version... and maybe it is the filename display that causes problems).

Marten

[martenrichter]

I tried to reproduce it, but I could not or maybe I could.
It may be that:
1.) Touch is activated on the Wacom tablet, and as the dialog has no palm rejection, your palm caused the selection.
2.) The following idea is very likely to only be recognizable if you have a zoom factor activated.
On my test setting, I had problems, if I switched between images with a larger size (so megabytes). In this case the loading and display of the changed image took longer (even though the filename on the right bottom changed) and it might have felt as if the previous image was selected.
This behavior is now addressed in cd8789a it will be released as version 1.2.9 .
As it is a bugfix release, it will be immediately released to the stable channel. (Deployment at TUB today or tomorrow, be aware that it may require a browser restart after updating the fails app in the browser to switch to the new version).

If the problem persists, I need more information about the involved pictures resolutions and browsers.

[marc-git]

Hi and thanks. It is for sure not related to palm rejection problems because this was off and I tried so many different ways to select the picture that it isn't possible. The pictures were all very wide in comparison to their height.

I was using Edge. I am not sure about the zoom level in the browser at that time. I didn't change it but I know some do.

[martenrichter]

Ok, as I see the picture were very cinemascope.
The file is not small but also not large, it could be that I had the right guess in fixing it.
Note, the new version crops the picture left and right, I have to fix this later...
I will try before my lecture, if I can reproduce it in EW 203 which has probably the same wacom tablet.

[martenrichter]

Ok, I could reproduce it.
But it only occurred with the pen of the Wacom device. Using the touchpad on the keyboard (it is technically a mouse) worked. I have to check, how I can reproduce it at home.

[martenrichter]

I did not check, if touch of the wacom device would work....

[martenrichter]

So touch does also not work, at least on the chromebook. Would take until next weekend at least. Until then please use the mouse pointer.

[martenrichter]

Problem identified. The cinemascope-like picture aspect ratio caused an overlap of the thumbnails with other thumbnails and the buttons and created horizontal scroll bars. This will be fixed in a release today evening and deployed over night.

[martenrichter]

41b0c29

[martenrichter]

fails-components/app@f6e11dd

[martenrichter]

Ok even though it is fixed for touch, it still persists for touch. The reason is probably the gallery element from the old primereact control not handling pen events correctly.
Possible ways of fixing:
1.) Writing of own picture selection control
2.) Hot patch UI element
3.) Newer primereact version, however, this is blocked, as this needs extensive work on custom scss styling.

[martenrichter]

Primereact component replaced by much simpler component unique to fails;
11ab33e

[marc-git]

So the selection of the images is better now, but only with the mouse. Should we close this? Or leave open to deal with that issue. With the pen selection is very unreliable.

[martenrichter]

Well, we should only close it, when it is reliable.
As it is now a completely new implementation, when does a problem occur in the selection? (But I can also try, to reproduce it at home).
So what kind of aspect ratio, is it hard to hit the control, so that I know, how to change it? (Compared to before, I have now full control, as it is now a custom widget.)