From c6e07bf62e8f5e575f548d848cb2f9c3135b0773 Mon Sep 17 00:00:00 2001 From: avinashpipalwa Date: Wed, 6 Jul 2022 15:17:44 +0530 Subject: [PATCH 1/2] fix(SDK): Added Holdings Mode for PA API Code Snippet Made the changes as per the requirement. Tested this and can see in the post body the Holdings mode which we passed as an input. --- examples/pa_engine_multiple_unit_example.py | 5 +++-- examples/pa_engine_single_unit_example.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/pa_engine_multiple_unit_example.py b/examples/pa_engine_multiple_unit_example.py index 39eacf54..f3cf3f23 100644 --- a/examples/pa_engine_multiple_unit_example.py +++ b/examples/pa_engine_multiple_unit_example.py @@ -49,6 +49,7 @@ def main(): startdate = "20180101" enddate = "20181231" frequency = "Monthly" + holdings = "B&H" # uncomment the below code line to setup cache control; max-stale=0 will be a fresh adhoc run and the max-stale value is in seconds. # Results are by default cached for 12 hours; Setting max-stale=300 will fetch a cached result which is 5 minutes older. # cache_control = "max-stale=0" @@ -56,8 +57,8 @@ def main(): component_id = [id for id in list( get_components_response[0].data.keys()) if get_components_response[0].data[id].name == pa_component_name and get_components_response[0].data[id].category == pa_component_category][0] print("PA Component Id: " + component_id) - pa_accounts = [PAIdentifier(id=portfolio)] - pa_benchmarks = [PAIdentifier(id=benchmark)] + pa_accounts = [PAIdentifier(id=portfolio,holdingsmode=holdings)] + pa_benchmarks = [PAIdentifier(id=benchmark,holdingsmode=holdings)] pa_dates = PADateParameters( startdate=startdate, enddate=enddate, frequency=frequency) diff --git a/examples/pa_engine_single_unit_example.py b/examples/pa_engine_single_unit_example.py index 8c11328c..ecd77a3a 100644 --- a/examples/pa_engine_single_unit_example.py +++ b/examples/pa_engine_single_unit_example.py @@ -49,6 +49,7 @@ def main(): startdate = "20180101" enddate = "20181231" frequency = "Monthly" + holdings = "B&H" # uncomment the below code line to setup cache control; max-stale=0 will be a fresh adhoc run and the max-stale value is in seconds. # Results are by default cached for 12 hours; Setting max-stale=300 will fetch a cached result which is 5 minutes older. # cache_control = "max-stale=0" @@ -56,8 +57,8 @@ def main(): component_id = [id for id in list( get_components_response[0].data.keys()) if get_components_response[0].data[id].name == pa_component_name and get_components_response[0].data[id].category == pa_component_category][0] print("PA Component Id: " + component_id) - pa_accounts = [PAIdentifier(id=portfolio)] - pa_benchmarks = [PAIdentifier(id=benchmark)] + pa_accounts = [PAIdentifier(id=portfolio,holdingsmode=holdings)] + pa_benchmarks = [PAIdentifier(id=benchmark,holdingsmode=holdings)] pa_dates = PADateParameters( startdate=startdate, enddate=enddate, frequency=frequency) From decaa7591b929a84e0565310f622cf13509aa132 Mon Sep 17 00:00:00 2001 From: avinashpipalwa Date: Wed, 6 Jul 2022 17:04:38 +0530 Subject: [PATCH 2/2] fix(SDK): Added Holdings Mode for PA API Code Snippets Added a space after comma --- examples/pa_engine_multiple_unit_example.py | 4 ++-- examples/pa_engine_single_unit_example.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/pa_engine_multiple_unit_example.py b/examples/pa_engine_multiple_unit_example.py index f3cf3f23..62a407a5 100644 --- a/examples/pa_engine_multiple_unit_example.py +++ b/examples/pa_engine_multiple_unit_example.py @@ -57,8 +57,8 @@ def main(): component_id = [id for id in list( get_components_response[0].data.keys()) if get_components_response[0].data[id].name == pa_component_name and get_components_response[0].data[id].category == pa_component_category][0] print("PA Component Id: " + component_id) - pa_accounts = [PAIdentifier(id=portfolio,holdingsmode=holdings)] - pa_benchmarks = [PAIdentifier(id=benchmark,holdingsmode=holdings)] + pa_accounts = [PAIdentifier(id=portfolio, holdingsmode=holdings)] + pa_benchmarks = [PAIdentifier(id=benchmark, holdingsmode=holdings)] pa_dates = PADateParameters( startdate=startdate, enddate=enddate, frequency=frequency) diff --git a/examples/pa_engine_single_unit_example.py b/examples/pa_engine_single_unit_example.py index ecd77a3a..d923b628 100644 --- a/examples/pa_engine_single_unit_example.py +++ b/examples/pa_engine_single_unit_example.py @@ -57,8 +57,8 @@ def main(): component_id = [id for id in list( get_components_response[0].data.keys()) if get_components_response[0].data[id].name == pa_component_name and get_components_response[0].data[id].category == pa_component_category][0] print("PA Component Id: " + component_id) - pa_accounts = [PAIdentifier(id=portfolio,holdingsmode=holdings)] - pa_benchmarks = [PAIdentifier(id=benchmark,holdingsmode=holdings)] + pa_accounts = [PAIdentifier(id=portfolio, holdingsmode=holdings)] + pa_benchmarks = [PAIdentifier(id=benchmark, holdingsmode=holdings)] pa_dates = PADateParameters( startdate=startdate, enddate=enddate, frequency=frequency)