Skip to content

Commit 4ccd1e6

Browse files
committed
Hotfix: urlencode credentials in clientSecret
1 parent 41dfc39 commit 4ccd1e6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/AuthMethod/ClientSecretBasic.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function createRequest(
3131

3232
$request = $request->withHeader(
3333
'Authorization',
34-
'Basic ' . base64_encode($clientId . ':' . $clientSecret)
34+
'Basic ' . base64_encode(urlencode($clientId) . ':' . urlencode($clientSecret))
3535
);
3636

3737
$request->getBody()->write(http_build_query($claims));

tests/AuthMethod/ClientSecretBasicTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ public function testCreateRequest(): void
3232
$metadata = $this->prophesize(ClientMetadataInterface::class);
3333

3434
$client->getMetadata()->willReturn($metadata->reveal());
35-
$metadata->getClientId()->willReturn('foo');
36-
$metadata->getClientSecret()->willReturn('bar');
35+
$metadata->getClientId()->willReturn('fooo');
36+
$metadata->getClientSecret()->willReturn('bar%');
3737

38-
$request->withHeader('Authorization', 'Basic ' . base64_encode('foo:bar'))
38+
$request->withHeader('Authorization', 'Basic ' . base64_encode('fooo:bar%25'))
3939
->shouldBeCalled()
4040
->willReturn($requestWithHeader->reveal());
4141

0 commit comments

Comments
 (0)