Skip to content

Commit 1c7736b

Browse files
committed
--update method name for SensorAttributesManager
1 parent 108d92b commit 1c7736b

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/esp/metadata/managers/SensorAttributesManager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ AbstractSensorAttributes::ptr SensorAttributesManager::buildObjectFromJSONDoc(
158158
return sensorAttributes;
159159
} // SensorAttributesManager::buildObjectFromJSONDoc
160160

161-
void SensorAttributesManager::setValsFromJSONDoc(
161+
void SensorAttributesManager::setValsFromJSONDocInternal(
162162
AbstractSensorAttributes::ptr attribs,
163163
const io::JsonGenericValue& jsonConfig) {
164164
// TODO support loading values from JSON docs for each type of

src/esp/metadata/managers/SensorAttributesManager.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,6 @@ class SensorAttributesManager
9898
const std::string& filename,
9999
const io::JsonGenericValue& jsonConfig) override;
100100

101-
/**
102-
* @brief Method to take an existing attributes and set its values from passed
103-
* json config file.
104-
* @param attribs (out) an existing attributes to be modified.
105-
* @param jsonConfig json document to parse
106-
*/
107-
void setValsFromJSONDoc(attributes::AbstractSensorAttributes::ptr attribs,
108-
const io::JsonGenericValue& jsonConfig) override;
109-
110101
/**
111102
* @brief This function will be called to finalize attributes' paths before
112103
* registration, moving fully qualified paths to the appropriate hidden
@@ -119,6 +110,16 @@ class SensorAttributesManager
119110
attributes) const override {}
120111

121112
protected:
113+
/**
114+
* @brief Internally accessed from AbstractAttributesManager. Method to take
115+
* an existing attributes and set its values from passed json config file.
116+
* @param attribs (out) an existing attributes to be modified.
117+
* @param jsonConfig json document to parse
118+
*/
119+
void setValsFromJSONDocInternal(
120+
attributes::AbstractSensorAttributes::ptr attribs,
121+
const io::JsonGenericValue& jsonConfig) override;
122+
122123
/**
123124
* @brief Internal only. Create an attributes from a SensorSpec.
124125
*

0 commit comments

Comments
 (0)