Skip to content

Commit c88647d

Browse files
committed
Don't show the coverage message if the targets are empty
1 parent 0c00eba commit c88647d

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

Sources/DangerDependencies/Fake.swift

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

Sources/DangerSwiftCoverage/XcodeBuild/XcodeBuildCoverageParser.swift

+4-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ enum XcodeBuildCoverageParser: XcodeBuildCoverageParsing {
1616
var coverage = try JSONDecoder().decode(XcodeBuildCoverage.self, from: data)
1717
coverage = coverage.filteringTargets(notOn: files, excludedTargets: excludedTargets)
1818

19-
return Report(messages: ["Project coverage: \(coverage.percentageCoverage.description)%"],
20-
sections: coverage.targets.map { ReportSection(fromTarget: $0) })
19+
let targets = coverage.targets.map { ReportSection(fromTarget: $0) }
20+
let messages = !targets.isEmpty ? ["Project coverage: \(coverage.percentageCoverage.description)%"] : []
21+
22+
return Report(messages: messages, sections: targets)
2123
}
2224
}

Tests/DangerSwiftCoverageTests/XcodeBuildCoverageParserTests.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ final class XcodeBuildCoverageParserTests: XCTestCase {
8383

8484
let result = try! XcodeBuildCoverageParser.coverage(xcresultBundlePath: "derived", files: files, excludedTargets: [], coverageFileFinder: FakeXcodeCoverageFileFinder.self, xcCovParser: MockedXcCovJSONParser.self)
8585

86-
XCTAssertEqual(result.messages, ["Project coverage: 50.09%"])
86+
XCTAssertEqual(result.messages, [])
87+
XCTAssertEqual(result.sections.count, 0)
8788
}
8889
}
8990

0 commit comments

Comments
 (0)