-
Notifications
You must be signed in to change notification settings - Fork 6
Test improvements, some other bits to make life easier for people working in automation #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mediocretes
wants to merge
7
commits into
master
Choose a base branch
from
test_improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e77ce26
Add completions for our current version of terraform, using tfenv as …
mediocretes 7553933
add modes and commands for running tests directly in emacs. Just for …
mediocretes e875267
export a flag to disable objc fork safety. this is required in order …
mediocretes 45ae764
Make some Quality of Life improvements to the repeat() bash function.
mediocretes 4f53990
Fix a bug in the previous commit related to counting failures. Also, …
mediocretes ae87280
The opposite of the merge in which I extracted the OBJC fork variable…
mediocretes dbe19a1
When repeat finishes, send a notification to the notification center.
mediocretes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line overrides the if statement above, so should that if statement (and its corresponding code in script/setup) be removed? Or is there a more variable way to do this that will autocomplete with whichever one we wanted, instead of overriding it every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Terraform installs to different locations depending on home-brew vs tfenv and intel vs apple chips. At this point, we can probably just assume both apple silicon and tfenv are in use and just use that for completions. Of course, we should probably use the default or highest version in tfenv, rather than just insisting on 1.4.2...
I might break these into 2 or 3 PRs. For the purposes of my current project, the line I really NEED is
The rest is just stuff I've had locally but which isn't really required for day to day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah since we're the only ones running this code, and we all have Apple Silicon, that's a safe bet. Besides this everything looks good, so I'll approve it.