Skip to content

Commit bf3f51b

Browse files
committed
Removed redundand rebuild of sqlite3 package
1 parent ad67011 commit bf3f51b

File tree

5 files changed

+9
-15
lines changed

5 files changed

+9
-15
lines changed

.github/workflows/build_and_test.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ jobs:
4141
- name: Install dependencies
4242
run: npm ci
4343

44-
- name: Rebuild sqlite3
45-
run: npm rebuild sqlite3
46-
4744
- name: Build TS
4845
run: npm run build:ts
4946

samples/simple-ts/tsup.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default defineConfig({
66
dts: true, // generate dts files
77
format: ['cjs', 'esm'], // generate cjs and esm files
88
minify: true, //env === 'production',
9-
bundle: false, //env === 'production',
9+
bundle: true, //env === 'production',
1010
skipNodeModulesBundle: true,
1111
target: 'esnext',
1212
outDir: 'dist', //env === 'production' ? 'dist' : 'lib',

src/packages/pongo/src/storage/postgresql/core/sqlBuilder/filter/index.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ const constructComplexFilterQuery = (
2828
const isEquality = !hasOperators(value);
2929

3030
return SQL.merge(
31-
objectEntries(value).map(
32-
([nestedKey, val]) =>
33-
isEquality
34-
? handleOperator(`${key}.${nestedKey}`, QueryOperators.$eq, val) // regular value
35-
: handleOperator(key, nestedKey, val), // operator
31+
objectEntries(value).map(([nestedKey, val]) =>
32+
isEquality
33+
? handleOperator(`${key}.${nestedKey}`, QueryOperators.$eq, val)
34+
: handleOperator(key, nestedKey, val),
3635
),
3736
` ${AND} `,
3837
);

src/packages/pongo/src/storage/sqlite/core/sqlBuilder/filter/index.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ const constructComplexFilterQuery = (
2828
const isEquality = !hasOperators(value);
2929

3030
return SQL.merge(
31-
objectEntries(value).map(
32-
([nestedKey, val]) =>
33-
isEquality
34-
? handleOperator(`${key}.${nestedKey}`, QueryOperators.$eq, val) // regular value
35-
: handleOperator(key, nestedKey, val), // operator
31+
objectEntries(value).map(([nestedKey, val]) =>
32+
isEquality
33+
? handleOperator(`${key}.${nestedKey}`, QueryOperators.$eq, val)
34+
: handleOperator(key, nestedKey, val),
3635
),
3736
` ${AND} `,
3837
);

src/packages/pongo/src/storage/sqlite/core/sqlBuilder/filter/queryOperators.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export const handleOperator = (
6969
const jsonPath = buildJsonPath(path);
7070
const serializedValue = JSONSerializer.serialize(value);
7171

72-
// Check if all elements are present
7372
return SQL`(SELECT COUNT(*) FROM json_each(json(${serializedValue})) WHERE json_each.value NOT IN (SELECT value FROM json_each(data, '${SQL.plain(jsonPath)}'))) = 0`;
7473
}
7574
case '$size': {

0 commit comments

Comments
 (0)