eth/syncer: advance safe and finalized block #33038
Open
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running geth without a true consensus node, uses the beacon dev sync flow to advance the chain(
debug_syncRPC).I hit a restart stall of 13mins, after some debugging, I found it was caused by the blob pool, the pool’s limbo database never got pruned.
Finally, I found it was in the beacon dev sync, we hadn't set the finalized header, that prevent the blob pool to run the prune task.
So proposal to set the safe/finalized header, this will also let the JSON-RPC take benefits.