-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Holocene-D: Pipeline improvements tracker #12490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can this be closed? |
Moved the modular fork handling notes into its own issue #14756 |
In view of ethereum-optimism/design-docs#213 we can close this issue for now. |
Reopening as we still have 4 todos in the code for this issue:
Seems like those todos could potentially just be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Tracking (non-blocking) observations and todos from #12506
Reset
to be called recursively on previous stages? So going from a horizontal model, where the pipeline iterates over the stages andReset
s each, to a vertical model where each stage owns the previous and resets it. There's only a single Reset that actually makes a network call (L1Retrieval.Reset
), while all other resets simply clear some fields and slices, so there's no real value in stepping through each reset individually. Note that this is actually more consistent to how each stage also fetches data from the previous stage (prev.NextData
etc) - it is not fetched by the pipeline on each stage and then passed on to the next stage. I also choose to makeFlushChannel
work with this vertical ownership model as well. (And the Rust implementation of the DP also works with the same model.)DepositsOnlyPayloadAttributesRequest
case inEngDeriver.onPayloadProcess
can actually happen. To the best of my understanding the FCU call should already fail before during derivation.See also #12444
The text was updated successfully, but these errors were encountered: