Skip to content

Holocene-D: Pipeline improvements tracker #12490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
sebastianst opened this issue Oct 16, 2024 · 4 comments
Open
3 tasks

Holocene-D: Pipeline improvements tracker #12490

sebastianst opened this issue Oct 16, 2024 · 4 comments

Comments

@sebastianst
Copy link
Member

sebastianst commented Oct 16, 2024

Tracking (non-blocking) observations and todos from #12506

  • Garbage collect left-over state in state multiplexers?
  • Refactor Reset to be called recursively on previous stages? So going from a horizontal model, where the pipeline iterates over the stages and Resets each, to a vertical model where each stage owns the previous and resets it. There's only a single Reset that actually makes a network call (L1Retrieval.Reset), while all other resets simply clear some fields and slices, so there's no real value in stepping through each reset individually. Note that this is actually more consistent to how each stage also fetches data from the previous stage (prev.NextData etc) - it is not fetched by the pipeline on each stage and then passed on to the next stage. I also choose to make FlushChannel work with this vertical ownership model as well. (And the Rust implementation of the DP also works with the same model.)
  • Clarify if the DepositsOnlyPayloadAttributesRequest case in EngDeriver.onPayloadProcess can actually happen. To the best of my understanding the FCU call should already fail before during derivation.

See also #12444

@protolambda
Copy link
Contributor

Can this be closed?

@sebastianst
Copy link
Member Author

Moved the modular fork handling notes into its own issue #14756

@sebastianst
Copy link
Member Author

In view of ethereum-optimism/design-docs#213 we can close this issue for now.

@ajsutton
Copy link
Contributor

Reopening as we still have 4 todos in the code for this issue:

ethereum-optimism/optimism #12490        | Holocene-D: Pipeline improvements tracker                         | op-node/rollup/types_test.go:779                  
ethereum-optimism/optimism #12490        | Holocene-D: Pipeline improvements tracker                         | op-node/rollup/types.go:511                       
ethereum-optimism/optimism #12490        | Holocene-D: Pipeline improvements tracker                         | op-node/rollup/derive/batch_mux.go:35             
ethereum-optimism/optimism #12490        | Holocene-D: Pipeline improvements tracker                         | op-node/rollup/derive/channel_mux.go:39           

Seems like those todos could potentially just be removed.

@ajsutton ajsutton reopened this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants