Update Fault Proofs Explainer #1706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and and provide guidance for `op-challenger` usage
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis update modifies the fault proofs explainer documentation by adding a new FAQ entry about guides for running the proposer and challenger roles. It clarifies that while these roles are open to everyone, typical users are not expected to run Sequence Diagram(s)Not applicable: The changes are limited to documentation updates and do not introduce or modify any control flow or feature logic. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/stack/fault-proofs/explainer.mdx (1)
90-97: Remove bold emphasis & streamline phrasing to match docs style-guideDocs guidance discourages bold for emphasis and prefers concise, impersonal wording.
-It's not expected that normal users run `op-proposer` to regularly propose output roots. -Users would generally just propose a single output root if they need to withdraw and the chain operator isn't proposing outputs for them via direct calls to the `DisputeGameFactory` via Etherscan. +Typical users are not expected to run `op-proposer` on a regular basis. +If a chain operator has not proposed an output, a user can submit a single output root by calling `DisputeGameFactory` directly through Etherscan. -The [`create-game`](https://github.com/ethereum-optimism/optimism/tree/develop/op-challenger#create-game) subcommand of `op-challenger` is **for testing purposes only** and should not be used in production environments. It is not intended as a replacement for proper `op-proposer` infrastructure. +The [`create-game`](https://github.com/ethereum-optimism/optimism/tree/develop/op-challenger#create-game) subcommand of `op-challenger` is for testing purposes only and must not be used in production environments. It is not intended to replace proper `op-proposer` infrastructure.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/stack/fault-proofs/explainer.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.mdx
⚙️ CodeRabbit Configuration File
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When rev...
Files:
pages/stack/fault-proofs/explainer.mdx
🧠 Learnings (4)
📓 Common learnings
Learnt from: qbzzt
PR: ethereum-optimism/docs#1216
File: pages/stack/interop/security.mdx:136-144
Timestamp: 2025-01-08T11:04:45.361Z
Learning: In the ethereum-optimism/docs repository, sections that are commented out in documentation files are intentionally excluded due to accuracy concerns and should not be suggested for inclusion until the information becomes accurate.
Learnt from: qbzzt
PR: ethereum-optimism/docs#1613
File: public/tutorials/attest.mjs:64-71
Timestamp: 2025-05-24T18:24:46.628Z
Learning: For tutorial and educational code in the ethereum-optimism/docs repository, prioritize simplicity and clarity over production-level robustness. Hardcoded values and simplified error handling are acceptable when they help demonstrate core concepts without unnecessary complexity.
Learnt from: qbzzt
PR: ethereum-optimism/docs#1390
File: public/tutorials/CustomSuperchainToken.sol:32-38
Timestamp: 2025-02-20T16:55:42.917Z
Learning: In tutorial and example code for the ethereum-optimism/docs repository, prioritize code clarity and simplicity over additional security measures or optimizations, unless they are specifically part of the learning objectives.
📚 Learning: prefer using 'op stack' over 'op mainnet' in documentation for consistency....
Learnt from: sbvegan
PR: ethereum-optimism/docs#1001
File: pages/builders.mdx:11-12
Timestamp: 2024-10-22T02:58:02.175Z
Learning: Prefer using 'OP Stack' over 'OP Mainnet' in documentation for consistency.
Applied to files:
pages/stack/fault-proofs/explainer.mdx
📚 Learning: for tutorial and educational code in the ethereum-optimism/docs repository, prioritize simplicity an...
Learnt from: qbzzt
PR: ethereum-optimism/docs#1613
File: public/tutorials/attest.mjs:64-71
Timestamp: 2025-05-24T18:24:46.628Z
Learning: For tutorial and educational code in the ethereum-optimism/docs repository, prioritize simplicity and clarity over production-level robustness. Hardcoded values and simplified error handling are acceptable when they help demonstrate core concepts without unnecessary complexity.
Applied to files:
pages/stack/fault-proofs/explainer.mdx
📚 Learning: in tutorial and example code for the ethereum-optimism/docs repository, prioritize code clarity and ...
Learnt from: qbzzt
PR: ethereum-optimism/docs#1390
File: public/tutorials/CustomSuperchainToken.sol:32-38
Timestamp: 2025-02-20T16:55:42.917Z
Learning: In tutorial and example code for the ethereum-optimism/docs repository, prioritize code clarity and simplicity over additional security measures or optimizations, unless they are specifically part of the learning objectives.
Applied to files:
pages/stack/fault-proofs/explainer.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the fault proofs explainer to correct misleading information about the
op-challengertool and provide accurate docs links.Tests
Additional context
Metadata