Find GRPC & GRPC Linux Fixes (#101)

* Update enigma-dev submodule with latest CMake fixes that actually search for GRPC.
* Default GRPC to on for all platforms.
* Macro guard GRPC server plugin header in main window.
* Manually enter "127.0.0.1" for now since Linux GRPC has broken DNS currently which cannot resolve "localhost" address.
* Add test to check that `-nogrpc` flag works.

Author: fundies

CMakeLists.txt

@@ -1,7 +1,6 @@
 cmake_minimum_required(VERSION 3.11)
 
-include(CMakeDependentOption)
-cmake_dependent_option(RGM_ENABLE_GRPC_SERVER "Enable the GRPC client plugin for compilation and code analysis." ON "WIN32" OFF)
+option(RGM_ENABLE_GRPC_SERVER "Enable the GRPC client plugin for compilation and code analysis." ON)
 
 if (CMAKE_BUILD_TYPE MATCHES "Debug")
   set(EXE "RadialGM-Debug")
@@ -181,15 +180,15 @@ endif()
 
 message(STATUS "Initial build flags:")
 set(CompilerFlags
-	  CMAKE_C_FLAGS_DEBUG
-	  CMAKE_C_FLAGS_MINSIZEREL
-	  CMAKE_C_FLAGS_RELEASE
-	  CMAKE_C_FLAGS_RELWITHDEBINFO
-	  CMAKE_CXX_FLAGS_DEBUG
-	  CMAKE_CXX_FLAGS_MINSIZEREL
-	  CMAKE_CXX_FLAGS_RELEASE
-	  CMAKE_CXX_FLAGS_RELWITHDEBINFO
-	  )
+    CMAKE_C_FLAGS_DEBUG
+    CMAKE_C_FLAGS_MINSIZEREL
+    CMAKE_C_FLAGS_RELEASE
+    CMAKE_C_FLAGS_RELWITHDEBINFO
+    CMAKE_CXX_FLAGS_DEBUG
+    CMAKE_CXX_FLAGS_MINSIZEREL
+    CMAKE_CXX_FLAGS_RELEASE
+    CMAKE_CXX_FLAGS_RELWITHDEBINFO
+    )
 
 foreach(CompilerFlag ${CompilerFlags})
   message(STATUS "  '${CompilerFlag}': ${${CompilerFlag}}")
@@ -213,17 +212,18 @@ include_directories(${EXE} PRIVATE ${RAPIDJSON_INCLUDE_DIRS})
 find_package(yaml-cpp CONFIG REQUIRED)
 target_link_libraries(${EXE} PRIVATE yaml-cpp)
 
-#Find gRPC
-if (MSVC) # Windows actually does something right for once
-  find_package(gRPC CONFIG REQUIRED)
-  target_link_libraries(${EXE} PRIVATE gRPC::gpr gRPC::grpc gRPC::grpc++)
-else() # https://tinyurl.com/arch-grpc-bug
-  find_library(LIB_GRPC_UNSECURE NAMES grpc++_unsecure)
-  find_library(LIB_GRPC NAMES grpc)
-  find_library(LIB_GPR NAMES gpr)
-  find_library(LIB_CARES NAMES cares)
-  find_library(LIB_ADDRESS_SORTING NAMES address_sorting)
-  target_link_libraries(${EXE} PRIVATE ${LIB_CARES} ${LIB_ADDRESS_SORTING} ${LIB_GPR} ${LIB_GRPC} ${LIB_GRPC_UNSECURE})
+if (RGM_ENABLE_GRPC_SERVER)
+  #Find gRPC
+  if (MSVC) # Windows actually does something right for once
+    find_package(gRPC CONFIG REQUIRED)
+    target_link_libraries(${EXE} PRIVATE gRPC::gpr gRPC::grpc gRPC::grpc++)
+  else() # https://tinyurl.com/arch-grpc-bug
+    find_library(LIB_GRPC_UNSECURE NAMES grpc++_unsecure)
+    find_library(LIB_GPR NAMES gpr)
+    find_library(LIB_CARES NAMES cares)
+    find_library(LIB_ADDRESS_SORTING NAMES address_sorting)
+    target_link_libraries(${EXE} PRIVATE ${LIB_CARES} ${LIB_ADDRESS_SORTING} ${LIB_GPR} ${LIB_GRPC_UNSECURE})
+  endif()
 endif()
 
 # Find Protobuf

MainWindow.cpp

@@ -20,7 +20,10 @@
 #include "Components/Logger.h"
 
 #include "Plugins/RGMPlugin.h"
+
+#ifdef RGM_SERVER_ENABLED
 #include "Plugins/ServerPlugin.h"
+#endif
 
 #include "gmk.h"
 #include "gmx.h"

Plugins/ServerPlugin.cpp

@@ -272,7 +272,8 @@ ServerPlugin::ServerPlugin(MainWindow& mainWindow) : RGMPlugin(mainWindow) {
   process->waitForStarted();
 
   // construct the channel and connect to the server running in the process
-  std::shared_ptr<Channel> channel = CreateChannel("localhost:37818", InsecureChannelCredentials());
+  // Note: gRPC is too dumb to resolve localhost on linux
+  std::shared_ptr<Channel> channel = CreateChannel("127.0.0.1:37818", InsecureChannelCredentials());
   compilerClient = new CompilerClient(channel, mainWindow);
   connect(compilerClient, &CompilerClient::CompileStatusChanged, this, &RGMPlugin::CompileStatusChanged);
   // hookup emake's output to our plugin's output signals so it redirects to the

Submodules/enigma-dev

@@ -199,17 +199,62 @@ jobs:
         sudo mount --bind ./root.x86_64/ ./root.x86_64/
         sudo cp -R  $(Build.SourcesDirectory) ./root.x86_64/RGM
         cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
         echo 'Server = https://mirrors.kernel.org/archlinux/\$repo/os/\$arch' >> /etc/pacman.d/mirrorlist
         pacman-key --init 
         pacman-key --populate archlinux
-        pacman -Sy --noconfirm base base-devel git gcc cmake protobuf grpc yaml-cpp pugixml rapidjson boost qt5 qscintilla-qt5
+        pacman -Sy --noconfirm base base-devel git gcc cmake protobuf yaml-cpp pugixml rapidjson boost qt5 qscintilla-qt5
         EOF
       displayName: 'Bootstrap Archlinux'
+
+    - bash: |
+        set -e
+        cd $(Build.BinariesDirectory)
+        cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
+        cd RGM
+        mkdir build
+        cd build
+        cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=MinSizeRel -DRGM_ENABLE_GRPC_SERVER=OFF ..
+        make
+        make install
+        cd ..
+        git clean -fx
+        rm -rf build/
+        EOF
+      displayName: 'Release Build (No gRPC)'
+    
+    - bash: |
+        set -e
+        cd $(Build.BinariesDirectory)
+        cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
+        cd RGM
+        mkdir build
+        cd build
+        cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Debug -DRGM_ENABLE_GRPC_SERVER=OFF ..
+        make
+        make install
+        cd ..
+        git clean -fx
+        rm -rf build/
+        EOF
+      displayName: 'Debug Build (No gRPC)'
+
+    - bash: |
+        set -e
+        cd $(Build.BinariesDirectory)
+        cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
+        pacman -S --noconfirm grpc
+        EOF
+      displayName: 'Install gRPC'
     
     - bash: |
         set -e
         cd $(Build.BinariesDirectory)
         cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
         cd RGM
         mkdir build
         cd build
@@ -218,13 +263,15 @@ jobs:
         make install
         cd ..
         git clean -fx
+        rm -rf build/
         EOF
       displayName: 'Release Build'
     
     - bash: |
         set -e
         cd $(Build.BinariesDirectory)
         cat << EOF | sudo ./root.x86_64/bin/arch-chroot ./root.x86_64/
+        set -e
         cd RGM
         mkdir build
         cd build
@@ -233,6 +280,7 @@ jobs:
         make install
         cd ..
         git clean -fx
+        rm -rf build/
         EOF
       displayName: 'Debug Build'